From: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
To: gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
"Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Subject: [PATCH 03/27] tty: switch tty_port::xmit_* to u8
Date: Wed, 6 Dec 2023 08:36:48 +0100 [thread overview]
Message-ID: <20231206073712.17776-4-jirislaby@kernel.org> (raw)
In-Reply-To: <20231206073712.17776-1-jirislaby@kernel.org>
Both xmit_buf and xmit_fifo of struct tty_port should be u8. To conform
to characters in the rest of the tty layer.
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
---
drivers/tty/tty_port.c | 2 +-
include/linux/tty_port.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/tty_port.c b/drivers/tty/tty_port.c
index ef72d2e4b928..14cca33d2269 100644
--- a/drivers/tty/tty_port.c
+++ b/drivers/tty/tty_port.c
@@ -247,7 +247,7 @@ int tty_port_alloc_xmit_buf(struct tty_port *port)
/* We may sleep in get_zeroed_page() */
mutex_lock(&port->buf_mutex);
if (port->xmit_buf == NULL) {
- port->xmit_buf = (unsigned char *)get_zeroed_page(GFP_KERNEL);
+ port->xmit_buf = (u8 *)get_zeroed_page(GFP_KERNEL);
if (port->xmit_buf)
kfifo_init(&port->xmit_fifo, port->xmit_buf, PAGE_SIZE);
}
diff --git a/include/linux/tty_port.h b/include/linux/tty_port.h
index 3276311a7f38..1b861f2100b6 100644
--- a/include/linux/tty_port.h
+++ b/include/linux/tty_port.h
@@ -114,8 +114,8 @@ struct tty_port {
unsigned char console:1;
struct mutex mutex;
struct mutex buf_mutex;
- unsigned char *xmit_buf;
- DECLARE_KFIFO_PTR(xmit_fifo, unsigned char);
+ u8 *xmit_buf;
+ DECLARE_KFIFO_PTR(xmit_fifo, u8);
unsigned int close_delay;
unsigned int closing_wait;
int drain_delay;
--
2.43.0
next prev parent reply other threads:[~2023-12-06 7:37 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 7:36 [PATCH 00/27] tty: type unifications -- the last part Jiri Slaby (SUSE)
2023-12-06 7:36 ` [PATCH 01/27] tty: goldfish: use bool for is_write parameter Jiri Slaby (SUSE)
2023-12-06 7:36 ` [PATCH 02/27] tty: mmc: sdio_uart: switch sdio_in() to return u8 Jiri Slaby (SUSE)
2023-12-07 14:09 ` Ulf Hansson
2023-12-06 7:36 ` Jiri Slaby (SUSE) [this message]
2023-12-06 7:36 ` [PATCH 04/27] tty: make tty_operations::send_xchar accept u8 char Jiri Slaby (SUSE)
2023-12-06 8:27 ` Geert Uytterhoeven
2023-12-07 14:09 ` Ulf Hansson
2023-12-06 7:36 ` [PATCH 05/27] tty: core: the rest to u8 Jiri Slaby (SUSE)
2023-12-06 7:36 ` [PATCH 06/27] tty: ami: use u8 for characters and flag Jiri Slaby (SUSE)
2023-12-06 8:28 ` Geert Uytterhoeven
2023-12-06 7:36 ` [PATCH 07/27] tty: bcm: convert to u8 and size_t Jiri Slaby (SUSE)
2023-12-06 7:36 ` [PATCH 08/27] tty: con3215: " Jiri Slaby (SUSE)
2023-12-08 13:19 ` Alexander Gordeev
2023-12-06 7:36 ` [PATCH 09/27] tty: con3270: " Jiri Slaby (SUSE)
2023-12-08 13:19 ` Alexander Gordeev
2023-12-06 7:36 ` [PATCH 10/27] tty: ehv_bytechan: " Jiri Slaby (SUSE)
2023-12-06 7:36 ` [PATCH 11/27] tty: goldfish: " Jiri Slaby (SUSE)
2023-12-06 7:36 ` [PATCH 12/27] tty: hvc: " Jiri Slaby (SUSE)
2023-12-06 9:30 ` Christophe Leroy
2023-12-06 7:36 ` [PATCH 13/27] tty: ipoctal: " Jiri Slaby (SUSE)
2023-12-06 7:36 ` [PATCH 14/27] tty: m68k: nfcon: " Jiri Slaby (SUSE)
2023-12-06 7:51 ` Geert Uytterhoeven
2023-12-06 7:37 ` [PATCH 15/27] tty: mips_ejtag_fdc: use u8 for character pointers Jiri Slaby (SUSE)
2023-12-06 7:37 ` [PATCH 16/27] tty: mmc: sdio: use u8 for flag Jiri Slaby (SUSE)
2023-12-07 14:10 ` Ulf Hansson
2023-12-06 7:37 ` [PATCH 17/27] tty: moxa: convert to u8 and size_t Jiri Slaby (SUSE)
2023-12-06 7:37 ` [PATCH 18/27] tty: mxser: " Jiri Slaby (SUSE)
2023-12-06 7:37 ` [PATCH 19/27] tty: n_gsm: " Jiri Slaby (SUSE)
2023-12-06 7:37 ` [PATCH 20/27] tty: n_hdlc: " Jiri Slaby (SUSE)
2023-12-06 7:37 ` [PATCH 21/27] tty: nozomi: " Jiri Slaby (SUSE)
2023-12-07 12:50 ` Ilpo Järvinen
2023-12-06 7:37 ` [PATCH 22/27] tty: serdev: convert to u8 and size_t in serdev_controller_ops Jiri Slaby (SUSE)
2023-12-06 7:37 ` [PATCH 23/27] tty: serdev: convert to u8 and size_t Jiri Slaby (SUSE)
2023-12-06 8:09 ` Johan Hovold
2023-12-07 1:47 ` Greg KH
2023-12-07 8:19 ` Johan Hovold
2023-12-07 10:09 ` Greg KH
2023-12-06 7:37 ` [PATCH 24/27] tty: srmcons: " Jiri Slaby (SUSE)
2023-12-06 7:37 ` [PATCH 25/27] tty: ttyprintk: " Jiri Slaby (SUSE)
2023-12-06 7:37 ` [PATCH 26/27] tty: um: convert to u8/__u8 " Jiri Slaby (SUSE)
2023-12-06 7:37 ` [PATCH 27/27] tty: xtensa/iss: use u8 Jiri Slaby (SUSE)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231206073712.17776-4-jirislaby@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox