From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id D1B74C10DC1
	for <linux-kernel@archiver.kernel.org>; Wed,  6 Dec 2023 09:24:29 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1346777AbjLFJYV (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Wed, 6 Dec 2023 04:24:21 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55348 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1346728AbjLFJYS (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 6 Dec 2023 04:24:18 -0500
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89DF8D40
        for <linux-kernel@vger.kernel.org>; Wed,  6 Dec 2023 01:24:25 -0800 (PST)
Received: by verein.lst.de (Postfix, from userid 2407)
        id B04CF227AA8; Wed,  6 Dec 2023 10:24:20 +0100 (CET)
Date:   Wed, 6 Dec 2023 10:24:20 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     Werner Sembach <wse@tuxedocomputers.com>
Cc:     Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
        Christoph Hellwig <hch@lst.de>,
        Sagi Grimberg <sagi@grimberg.me>,
        Georg Gottleuber <ggo@tuxedocomputers.com>,
        linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme-pci: Add sleep quirk for Kingston drives
Message-ID: <20231206092420.GA27348@lst.de>
References: <20230920085210.22573-1-wse@tuxedocomputers.com> <12d32e8e-e20b-4023-8299-39d2a69c0cd9@tuxedocomputers.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <12d32e8e-e20b-4023-8299-39d2a69c0cd9@tuxedocomputers.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

What does save a lot of power mean, and why does it only apply to
some platforms?  I suspect the more likely case is that APST is
simply completely broken on this device?