From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5B13C4167B for ; Wed, 6 Dec 2023 11:17:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378154AbjLFLRM (ORCPT ); Wed, 6 Dec 2023 06:17:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377764AbjLFLRK (ORCPT ); Wed, 6 Dec 2023 06:17:10 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BCF6C3 for ; Wed, 6 Dec 2023 03:17:16 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD8CEC433C8; Wed, 6 Dec 2023 11:17:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701861436; bh=gvY0LwkFuS7ixR5SlQYIdlUtxHf1OCuXpDZAqJh4fmc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p5en7/pPxTpa/muofj345pgVWwgX/blV0jTQ7LyS59u2rTgS5SK6CswVed1Wn+duv 6hm3rncGMzMbizSPkIaI//TRd5HubPGg7rtAYIBADEMhilreLVe9U4I6YxJKn4tirr am4FGYvaTTVF5MDJ6hwK3D5Mq+DAetRpxbD6tH8xihU5Hil0O3pBXcNSR/ejwsfUuA 5zAx4TecjPKotwFVm/WqR+GQ01ERjRNnY5UwClyr8kufctDG29GCHcN9GG3jsA3SRz TuVL3zZesz7o1oEnstPzxBZYn7BxHX4BnNRvZDKepp2huXVUOUEEnQyrx4fKkVga7O XlkVFDaaZvAlQ== Date: Wed, 6 Dec 2023 16:47:07 +0530 From: Manivannan Sadhasivam To: Nitin Rawat Cc: Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Matthias Brugger , AngeloGioacchino Del Regno , Krzysztof Kozlowski , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, quic_cang@quicinc.com, Manish Pandey Subject: Re: [PATCH V1] scsi: ufs: core: store min and max clk freq from OPP table Message-ID: <20231206111707.GA12802@thinkpad> References: <20231206053628.32169-1-quic_nitirawa@quicinc.com> <20231206075447.GA4954@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 06, 2023 at 04:35:24PM +0530, Nitin Rawat wrote: > > > On 12/6/2023 1:24 PM, Manivannan Sadhasivam wrote: > > On Wed, Dec 06, 2023 at 11:06:28AM +0530, Nitin Rawat wrote: > > > OPP support will make use of OPP table in device tree and removes > > > freq-table-hz property from device tree. > > > > > > With OPP enabled in devicetree, clki->min_freq and clki->maxfreq > > > currently is not getting updated and the value is set to 0. > > > > > > Soc vendors like qcom, mediatek uses clki->minfreq and clki->maxfreq > > > in vendor specific file. These frequencies values are used to update > > > vendor specific configurations. Since the value is 0, it is causing > > > functional issue. > > > > How about, > > > > "OPP support added by commit 72208ebe181e ("scsi: ufs: core: Add support > > for parsing OPP") doesn't update the min_freq and max_freq of each clocks > > in 'struct ufs_clk_info'. > > > > But these values are used by the vendor host drivers internally for controller > > configuration. When the OPP support is enabled in devicetree, these values will > > be 0, causing boot issues on the respective platforms. > > > > So let's parse the min_freq and max_freq of all clocks while parsing the OPP > > table." > > > > > > > > Add code to store the min and max ufs clk frequency from OPP table. > > Sure. Will update in next patchset. > > > > > > > Fixes: 72208ebe181e ("scsi: ufs: core: Add support for parsing OPP") > > > Co-developed-by: Manish Pandey > > > Signed-off-by: Manish Pandey > > > Signed-off-by: Nitin Rawat > > > --- > > > drivers/ufs/host/ufshcd-pltfrm.c | 56 ++++++++++++++++++++++++++++++++ > > > 1 file changed, 56 insertions(+) > > > > > > diff --git a/drivers/ufs/host/ufshcd-pltfrm.c b/drivers/ufs/host/ufshcd-pltfrm.c > > > index da2558e274b4..12fa6f7d6a97 100644 > > > --- a/drivers/ufs/host/ufshcd-pltfrm.c > > > +++ b/drivers/ufs/host/ufshcd-pltfrm.c > > > @@ -13,6 +13,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > > Sort includes alphabetically. > > Sure. Will update in next patchset > > > > > > > > > #include > > > #include "ufshcd-pltfrm.h" > > > @@ -213,6 +214,55 @@ static void ufshcd_init_lanes_per_dir(struct ufs_hba *hba) > > > } > > > } > > > > > > +/** > > > + * ufshcd_config_min_max_clk_freq - update min and max freq > > > > "ufshcd_parse_clock_min_max_freq - Parse MIN and MAX frequencies of clocks" > > > > > + * @hba: per adapter instance > > > + * > > > + * This function store min and max freq for all the clocks. > > > + * > > > > "This function parses MIN and MAX frequencies of all clocks required by the > > vendor host drivers." > > > > > + * Returns 0 for success and non-zero for failure > > > + */ > > > +static int ufshcd_config_min_max_clk_freq(struct ufs_hba *hba) > > > +{ > > > + struct list_head *head = &hba->clk_list_head; > > > + struct dev_pm_opp *opp; > > > + struct ufs_clk_info *clki; > > > > Please maintain reverse Xmas tree order. It's not a rule for this driver, but my > > own preference. > > > > > + unsigned long freq; > > > + u8 idx = 0; > > > + int ret; > > > > This won't be needed if all the return values are directly returned as I shared > > below. > > > Will Addressed all ret comments in next patchset. > > > > > + > > > + list_for_each_entry(clki, head, list) { > > > + if (!clki->name) > > > + continue; > > > + > > > + clki->clk = devm_clk_get(hba->dev, clki->name); > > > + if (!IS_ERR_OR_NULL(clki->clk)) { > > > > This function won't return NULL, so IS_ERR() is sufficient. > > > > > + /* Find Max Freq */ > > > + freq = ULONG_MAX; > > > + opp = dev_pm_opp_find_freq_floor_indexed(hba->dev, &freq, idx); > > > > Use idx++ and get rid of the increment at the end of the 'if' condition. > > If we increment idx++ here, dev_pm_opp_find_freq_ceil_indexed will use > incremented idx which is not correct. Hence i added at end after both the > call. Ah, right. Please increment it in dev_pm_opp_find_freq_ceil_indexed() instead. - Mani -- மணிவண்ணன் சதாசிவம்