From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D759C4167B for ; Wed, 6 Dec 2023 15:36:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379230AbjLFPgf (ORCPT ); Wed, 6 Dec 2023 10:36:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379142AbjLFPgd (ORCPT ); Wed, 6 Dec 2023 10:36:33 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A82D4C9 for ; Wed, 6 Dec 2023 07:36:39 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68019C433C8; Wed, 6 Dec 2023 15:36:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701876999; bh=S97fwyqurmhPwtoTkqcJFQVRifEWBxQOjTFb6lB82jI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=G5ww8XIj7dj3TZOJxaCrFTldYB5ca7IqnJXRhLRleaWSkgIe+SY0xz2qBP4v/NKYJ 7pBQdCA+52VAEdNfmXilhOziH6wYC+lzMplb4RD70B9MyZj1T5bj/8327FhqbkcKjs qlgCkt/U8gwmjFJ3R3vFwKnSwxLjtjmZ5usJyHE3olxbK1OFNXX9MwyWcZJnOz2sKD IdtEZMQJJr+GbNQRfakj5L38f7gBhehO87P8KHGBghrUfCHrjEl4O8tSqHWZbHqitz L4YVujLIp9vmo7HnBEDCEO2f4vF/GMhL/Begi9OwounWEY1el/YrWfmBEKrcn5Pgdw iXes2HaDLetew== Date: Wed, 6 Dec 2023 21:06:27 +0530 From: Manivannan Sadhasivam To: Manikanta Maddireddy Cc: bhelgaas@google.com, thierry.reding@gmail.com, petlozup@nvidia.com, rafael.j.wysocki@intel.com, lpieralisi@kernel.org, robh@kernel.org, jeffy.chen@rock-chips.com, krzysztof.kozlowski+dt@linaro.org, jonathanh@nvidia.com, dmitry.osipenko@collabora.com, viresh.kumar@linaro.org, gregkh@linuxfoundation.org, steven.price@arm.com, kw@linux.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, vidyas@nvidia.com Subject: Re: [RFC,v14 4/5] arm64: tegra: Add PCIe port node with PCIe WAKE# for C1 controller Message-ID: <20231206153627.GJ12802@thinkpad> References: <20230208111645.3863534-1-mmaddireddy@nvidia.com> <20230208111645.3863534-5-mmaddireddy@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230208111645.3863534-5-mmaddireddy@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 08, 2023 at 04:46:44PM +0530, Manikanta Maddireddy wrote: > Add PCIe port node under the PCIe controller-1 device tree node to support > PCIe WAKE# interrupt for WiFi. > > Signed-off-by: Manikanta Maddireddy > --- > > Changes in v14: > New patch in the series to support PCIe WAKE# in NVIDIA Jetson AGX Orin. > > .../dts/nvidia/tegra234-p3737-0000+p3701-0000.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts > index 8a9747855d6b..9c89be263141 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts > +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts > @@ -2147,6 +2147,17 @@ pcie@14100000 { > > phys = <&p2u_hsio_3>; > phy-names = "p2u-0"; > + > + pci@0,0 { > + reg = <0x0000 0 0 0 0>; > + #address-cells = <3>; > + #size-cells = <2>; > + ranges; > + > + interrupt-parent = <&gpio>; > + interrupts = ; > + interrupt-names = "wakeup"; WAKE# should be part of the PCIe controller, not device. And the interrupt name should be "wake". - Mani > + }; > }; > > pcie@14160000 { > -- > 2.25.1 > -- மணிவண்ணன் சதாசிவம்