From: Peter Zijlstra <peterz@infradead.org>
To: Boqun Feng <boqun.feng@gmail.com>
Cc: "Alice Ryhl" <aliceryhl@google.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Wedson Almeida Filho" <wedsonaf@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@samsung.com>,
"Ingo Molnar" <mingo@redhat.com>, "Will Deacon" <will@kernel.org>,
"Waiman Long" <longman@redhat.com>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] rust: sync: add `CondVar::wait_timeout`
Date: Wed, 6 Dec 2023 17:39:45 +0100 [thread overview]
Message-ID: <20231206163945.GC36423@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <ZXChjmoKPj3XnJgG@Boquns-Mac-mini.home>
On Wed, Dec 06, 2023 at 08:30:06AM -0800, Boqun Feng wrote:
> On Wed, Dec 06, 2023 at 10:09:24AM +0000, Alice Ryhl wrote:
> [...]
> > +
> > +/// The return type of `wait_timeout`.
> > +pub enum CondVarTimeoutResult {
> > + /// The timeout was reached.
> > + Timeout,
> > + /// Somebody woke us up.
> > + Woken {
> > + /// Remaining sleep duration.
> > + jiffies: u64,
>
> I have a Jiffies definition in the my upcoming timer patchset:
>
> /// The time unit of Linux kernel. One jiffy equals (1/HZ) second.
> pub type Jiffies = core::ffi::c_ulong;
>
> Maybe you can add that (in a separate patch) in kernel::time?
Urgh, why are we using jiffies in 2023?
next prev parent reply other threads:[~2023-12-06 16:40 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 10:09 [PATCH 0/2] Additional CondVar methods needed by Rust Binder Alice Ryhl
2023-12-06 10:09 ` [PATCH 1/2] rust: sync: add `CondVar::notify_sync` Alice Ryhl
2023-12-06 15:49 ` Martin Rodriguez Reboredo
2023-12-07 20:21 ` Benno Lossin
2023-12-08 7:29 ` Alice Ryhl
2023-12-08 9:30 ` Benno Lossin
2023-12-06 10:09 ` [PATCH 2/2] rust: sync: add `CondVar::wait_timeout` Alice Ryhl
2023-12-06 15:53 ` Martin Rodriguez Reboredo
2023-12-06 16:38 ` Alice Ryhl
2023-12-06 16:30 ` Boqun Feng
2023-12-06 16:39 ` Peter Zijlstra [this message]
2023-12-06 16:42 ` Alice Ryhl
2023-12-06 16:53 ` Peter Zijlstra
2023-12-06 17:00 ` Alice Ryhl
2023-12-06 17:05 ` Tiago Lam
2023-12-08 7:37 ` Alice Ryhl
2023-12-08 9:27 ` Benno Lossin
2023-12-12 9:45 ` Alice Ryhl
2023-12-14 19:58 ` Boqun Feng
2023-12-14 20:04 ` [PATCH] rust: sync: Makes `CondVar::wait()` an uninterruptible wait Boqun Feng
2023-12-15 10:27 ` Alice Ryhl
2023-12-15 23:45 ` Boqun Feng
2023-12-18 17:39 ` Benno Lossin
2023-12-18 20:57 ` Boqun Feng
2023-12-15 11:58 ` Tiago Lam
2023-12-20 11:11 ` Benno Lossin
2023-12-21 21:43 ` Miguel Ojeda
2023-12-08 19:04 ` [PATCH 2/2] rust: sync: add `CondVar::wait_timeout` Benno Lossin
2023-12-12 9:51 ` Alice Ryhl
2023-12-12 17:05 ` Benno Lossin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231206163945.GC36423@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=a.hindborg@samsung.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=wedsonaf@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox