From: Tony Lindgren <tony@atomide.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Petr Mladek" <pmladek@suse.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"John Ogness" <john.ogness@linutronix.de>,
"Sergey Senozhatsky" <senozhatsky@chromium.org>,
"David S . Miller" <davem@davemloft.net>,
"Dhruva Gole" <d-gole@ti.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Johan Hovold" <johan@kernel.org>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v4 4/4] serial: 8250: Add preferred console in serial8250_isa_init_ports()
Date: Thu, 7 Dec 2023 09:23:41 +0200 [thread overview]
Message-ID: <20231207072341.GU5169@atomide.com> (raw)
In-Reply-To: <ZW9LBXc8ars-rrh6@smile.fi.intel.com>
* Andy Shevchenko <andriy.shevchenko@intel.com> [231205 16:08]:
> On Tue, Dec 05, 2023 at 09:32:36AM +0200, Tony Lindgren wrote:
> > + name = kasprintf(GFP_KERNEL, "%s%i", serial8250_reg.dev_name, idx);
>
> No error check?
Oops
> > + ret = add_preferred_console_match(name, serial8250_reg.dev_name, idx);
> > + if (!ret || ret == -ENOENT)
> > + return;
>
> ret = serial_base_add_one_prefcon(...);
>
> ?
Yup that should work even before struct device. Will fix the other
places too you noticed.
Thanks,
Tony
next prev parent reply other threads:[~2023-12-07 7:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 7:32 [PATCH v4 0/4] Add support for DEVNAME:0.0 style hardware based addressing Tony Lindgren
2023-12-05 7:32 ` [PATCH v4 1/4] printk: Save console options for add_preferred_console_match() Tony Lindgren
2023-12-05 7:32 ` [PATCH v4 2/4] serial: core: Add support for DEVNAME:0.0 style naming for kernel console Tony Lindgren
2023-12-05 7:32 ` [PATCH v4 3/4] serial: core: Handle serial console options Tony Lindgren
2023-12-05 16:06 ` Andy Shevchenko
2023-12-05 7:32 ` [PATCH v4 4/4] serial: 8250: Add preferred console in serial8250_isa_init_ports() Tony Lindgren
2023-12-05 16:08 ` Andy Shevchenko
2023-12-05 16:10 ` Andy Shevchenko
2023-12-07 7:23 ` Tony Lindgren [this message]
2023-12-05 18:07 ` kernel test robot
2023-12-05 18:29 ` kernel test robot
2023-12-05 7:45 ` [PATCH v4 0/4] Add support for DEVNAME:0.0 style hardware based addressing Tony Lindgren
2023-12-08 8:28 ` Tony Lindgren
2023-12-18 6:38 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207072341.GU5169@atomide.com \
--to=tony@atomide.com \
--cc=andriy.shevchenko@intel.com \
--cc=bigeasy@linutronix.de \
--cc=d-gole@ti.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox