linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: David Ahern <dsahern@kernel.org>
Cc: Aron Silverton <aron.silverton@oracle.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Saeed Mahameed <saeed@kernel.org>,
	Jason Gunthorpe <jgg@nvidia.com>, Arnd Bergmann <arnd@arndb.de>,
	Leon Romanovsky <leonro@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
	Leonid Bloch <lbloch@nvidia.com>,
	Itay Avraham <itayavr@nvidia.com>,
	linux-kernel@vger.kernel.org, Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [PATCH V3 2/5] misc: mlx5ctl: Add mlx5ctl misc driver
Date: Thu, 7 Dec 2023 08:20:42 -0800	[thread overview]
Message-ID: <20231207082042.6229868e@kernel.org> (raw)
In-Reply-To: <2bbc4c40-ff8b-4243-9987-dc7d5502a37c@kernel.org>

David, I agree with your points. I think you're misreading
what I said.

On Thu, 7 Dec 2023 08:54:51 -0700 David Ahern wrote:
> You rail against out of tree drivers and vendor proprietary tools, and
> now you argue for just that.

I don't rail against out of tree drivers, very much the opposite.
Linux supports out of tree modules, and I agree that's 100% the
correct thing to do. I'd encourage more people to take advantage of
that. The problem is quite the opposite, all the "security hardening"
is making it almost impossible for users to take advantage of OOT
modules.

> There is no reason debugging capabilities
> can not be built into the OS and used when needed. That means anything
> needed - from kernel modules to userspace tools.
> 
> The Meta data point is not representative of the world at large -
> different scale, different needs, different expertise on staff (OS and
> H/W). Getting S/W installed (especially anything requiring a compiler)
> in a production server (and VMs) is not an easy request and in many
> cases not even possible.

I did not say it's easy.

> When a customer hits problem, the standard steps are to run a script,
> generate a tar file and ship it to the OS vendor. Engineers at the OS
> vendor go through it and may need other data - like getting detailed
> dumps from individual pieces of H/W.

You say that like this is not _exactly_ what I just said!?

> Every time those requests require
> going to a vendor web site to pull down vendor tools, get permission to
> install them, schedule the run of said tool ... it only serves to drag
> out the debugging process. ie., this open-ended stance only serves to
> hurt Linux users.

Right, exactly. What are you arguing with then? As I said - we have a
very open / accommodating policy for extracting all sort of debug and
state dumps. You can put whatever read only stuff you want in debugfs**
Read-write interfaces must be constrained to a clear set of commands /
settings but also very much allowed. As you said users need to be able
to extract debug info to share with the vendors, no tools necessary.

** (this will surprise you but you can also put stats there, if they 
    are custom, I don't care if they go into ethtool -S or debugfs)

  reply	other threads:[~2023-12-07 16:21 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-21  7:06 [PATCH V3 0/5] mlx5 ConnectX control misc driver Saeed Mahameed
2023-11-21  7:06 ` [PATCH V3 1/5] mlx5: Add aux dev for ctl interface Saeed Mahameed
2023-11-21  7:06 ` [PATCH V3 2/5] misc: mlx5ctl: Add mlx5ctl misc driver Saeed Mahameed
2023-11-27 13:36   ` Greg Kroah-Hartman
2023-11-27 14:40     ` Jason Gunthorpe
2023-11-27 15:51       ` Greg Kroah-Hartman
2023-11-27 16:17         ` Jason Gunthorpe
2023-11-27 18:27           ` Greg Kroah-Hartman
2023-11-27 19:26             ` Saeed Mahameed
2023-11-28  0:07               ` Jakub Kicinski
2023-11-28  4:46                 ` David Ahern
2023-11-28 14:53                   ` Jakub Kicinski
2023-11-28 16:24                     ` Jason Gunthorpe
2023-11-28 16:44                       ` Jakub Kicinski
2023-11-28 17:52                         ` Jason Gunthorpe
2023-11-28 18:33                           ` Jakub Kicinski
2023-11-28 19:55                             ` Saeed Mahameed
2023-11-28 20:10                             ` Saeed Mahameed
2023-11-29  9:08                               ` Greg Kroah-Hartman
2023-12-04 21:37                                 ` Aron Silverton
2023-12-05  2:52                                   ` Jakub Kicinski
2023-12-05 17:11                                     ` Aron Silverton
2023-12-06  4:48                                       ` Jakub Kicinski
2023-12-07 15:54                                         ` David Ahern
2023-12-07 16:20                                           ` Jakub Kicinski [this message]
2023-12-07 16:41                                         ` Aron Silverton
2023-12-07 17:23                                           ` Jakub Kicinski
2023-12-07 18:06                                             ` Aron Silverton
2023-12-07 19:02                                               ` Saeed Mahameed
2023-12-08  5:29                                                 ` Greg Kroah-Hartman
2023-12-08 13:34                                                   ` Jason Gunthorpe
2023-12-08  5:27                                               ` Greg Kroah-Hartman
2023-12-08 12:52                                                 ` Jason Gunthorpe
2023-12-07 18:54                                           ` Saeed Mahameed
2023-12-13 16:55                                             ` Christoph Hellwig
2023-11-28 19:31                         ` Saeed Mahameed
2023-11-28 16:52                     ` David Ahern
2023-11-27 18:59   ` Greg Kroah-Hartman
2023-11-29  9:08     ` Saeed Mahameed
2023-11-29  9:20       ` Greg Kroah-Hartman
2023-11-29 13:02         ` Jason Gunthorpe
2023-11-29 15:41           ` Greg Kroah-Hartman
2023-11-29 18:07             ` Jason Gunthorpe
2023-11-21  7:06 ` [PATCH V3 3/5] misc: mlx5ctl: Add info ioctl Saeed Mahameed
2023-11-27 19:09   ` Greg Kroah-Hartman
2023-11-27 20:39     ` Saeed Mahameed
2023-11-28  9:13       ` Greg Kroah-Hartman
2023-11-29  8:53         ` Saeed Mahameed
2023-11-21  7:06 ` [PATCH V3 4/5] misc: mlx5ctl: Add command rpc ioctl Saeed Mahameed
2023-11-21  7:06 ` [PATCH V3 5/5] misc: mlx5ctl: Add umem reg/unreg ioctl Saeed Mahameed
2023-11-21 20:44   ` Jakub Kicinski
2023-11-21 21:04     ` Saeed Mahameed
2023-11-21 22:10       ` Jakub Kicinski
2023-11-21 22:52         ` Saeed Mahameed
2023-11-21 22:18       ` David Ahern
2023-11-21 22:46         ` Saeed Mahameed
2023-11-21 23:46     ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231207082042.6229868e@kernel.org \
    --to=kuba@kernel.org \
    --cc=arnd@arndb.de \
    --cc=aron.silverton@oracle.com \
    --cc=dsahern@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=itayavr@nvidia.com \
    --cc=jgg@nvidia.com \
    --cc=jiri@nvidia.com \
    --cc=lbloch@nvidia.com \
    --cc=leonro@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=saeed@kernel.org \
    --cc=saeedm@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).