From: Peter Zijlstra <peterz@infradead.org>
To: Xiaolei Wang <xiaolei.wang@windriver.com>
Cc: rafael@kernel.org, pavel@ucw.cz, len.brown@intel.com,
mingo@kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] freezer,sched: Move state information judgment outside task_call_func
Date: Thu, 7 Dec 2023 13:35:45 +0100 [thread overview]
Message-ID: <20231207123545.GB36716@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20231207111634.667057-1-xiaolei.wang@windriver.com>
On Thu, Dec 07, 2023 at 07:16:34PM +0800, Xiaolei Wang wrote:
> It is dangerous to output warnings in task_call_func,
> which may lead to the risk of deadlock. task_call_func
> uses p->pi_lock, and the serial port output may call
> try_to_wake_up to wake up the write buff, which also
> uses p->pi_lock.
No, we're not going to make the code ugly because printk is stupid. Fix
whatever that triggers the WARN and leave it at that.
next prev parent reply other threads:[~2023-12-07 12:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 11:16 [PATCH] freezer,sched: Move state information judgment outside task_call_func Xiaolei Wang
2023-12-07 12:35 ` Peter Zijlstra [this message]
2023-12-07 19:30 ` kernel test robot
2023-12-07 21:06 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207123545.GB36716@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=xiaolei.wang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox