From: "Marek Behún" <kabel@kernel.org>
To: Sjoerd Simons <sjoerd@collabora.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] bus: moxtet: Mark the irq as shared
Date: Thu, 7 Dec 2023 15:09:17 +0100 [thread overview]
Message-ID: <20231207150917.6f69999c@dellmb> (raw)
In-Reply-To: <20231123142403.2262032-1-sjoerd@collabora.com>
On Thu, 23 Nov 2023 15:23:37 +0100
Sjoerd Simons <sjoerd@collabora.com> wrote:
> The Turris Mox shares the moxtet IRQ with various devices on the board,
> so mark the IRQ as shared in the driver as well.
>
> Without this loading the module will fail with:
> genirq: Flags mismatch irq 40. 00002002 (moxtet) vs. 00002080 (mcp7940x)
>
> Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>
> ---
>
> drivers/bus/moxtet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/moxtet.c b/drivers/bus/moxtet.c
> index 5eb0fe73ddc4..48c18f95660a 100644
> --- a/drivers/bus/moxtet.c
> +++ b/drivers/bus/moxtet.c
> @@ -755,7 +755,7 @@ static int moxtet_irq_setup(struct moxtet *moxtet)
> moxtet->irq.masked = ~0;
>
> ret = request_threaded_irq(moxtet->dev_irq, NULL, moxtet_irq_thread_fn,
> - IRQF_ONESHOT, "moxtet", moxtet);
> + IRQF_SHARED | IRQF_ONESHOT, "moxtet", moxtet);
> if (ret < 0)
> goto err_free;
>
Reviewed-by: Marek Behún <kabel@kernel.org>
prev parent reply other threads:[~2023-12-07 14:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 14:23 [PATCH 1/2] bus: moxtet: Mark the irq as shared Sjoerd Simons
2023-11-23 14:23 ` [PATCH 2/2] bus: moxtet: Add spi device table Sjoerd Simons
2023-12-07 14:09 ` Marek Behún
2023-12-07 14:09 ` Marek Behún [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207150917.6f69999c@dellmb \
--to=kabel@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sjoerd@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox