From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E242C4167B for ; Thu, 7 Dec 2023 15:33:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1443532AbjLGPdu (ORCPT ); Thu, 7 Dec 2023 10:33:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1443479AbjLGPds (ORCPT ); Thu, 7 Dec 2023 10:33:48 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9229310CA for ; Thu, 7 Dec 2023 07:33:54 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 110BF227A87; Thu, 7 Dec 2023 16:33:52 +0100 (CET) Date: Thu, 7 Dec 2023 16:33:51 +0100 From: Christoph Hellwig To: Daniel Wagner Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Keith Busch , Christoph Hellwig , Sagi Grimberg , Hannes Reinecke Subject: Re: [PATCH v4 4/4] nvme: repack struct nvme_ns_head Message-ID: <20231207153351.GC21486@lst.de> References: <20231207123624.29959-1-dwagner@suse.de> <20231207123624.29959-5-dwagner@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231207123624.29959-5-dwagner@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 07, 2023 at 01:36:24PM +0100, Daniel Wagner wrote: > ns_id, lba_shift and ms are always accessed for every read/write I/O in > nvme_setup_rw. By grouping these variables into one cacheline we can > safe some cycles. > > 4k sequential reads: > > baseline patched > Bandwidth: 1620 1634 > IOPs 66345579 66910939 Nice: Reviewed-by: Christoph Hellwig