From: Rob Herring <robh@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nipun Gupta <nipun.gupta@amd.com>,
Nikhil Agarwal <nikhil.agarwal@amd.com>,
Abhijit Gangurde <abhijit.gangurde@amd.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] cdx: Explicitly include correct DT includes, again
Date: Thu, 7 Dec 2023 10:31:27 -0600 [thread overview]
Message-ID: <20231207163128.2707993-2-robh@kernel.org> (raw)
In-Reply-To: <20231207163128.2707993-1-robh@kernel.org>
The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it was merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.
CDX was fixed once, but commit ("cdx: Remove cdx controller list from cdx
bus system") added another occurrence.
Fixes: 54b406e10f03 ("cdx: Remove cdx controller list from cdx bus system")
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/cdx/cdx.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/cdx/cdx.c b/drivers/cdx/cdx.c
index 4461c6c9313f..d84d153078d7 100644
--- a/drivers/cdx/cdx.c
+++ b/drivers/cdx/cdx.c
@@ -57,7 +57,10 @@
#include <linux/init.h>
#include <linux/kernel.h>
+#include <linux/of.h>
#include <linux/of_device.h>
+#include <linux/of_platform.h>
+#include <linux/platform_device.h>
#include <linux/slab.h>
#include <linux/mm.h>
#include <linux/idr.h>
--
2.42.0
next prev parent reply other threads:[~2023-12-07 16:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 16:31 [PATCH 1/2] cdx: Enable COMPILE_TEST Rob Herring
2023-12-07 16:31 ` Rob Herring [this message]
2023-12-12 4:40 ` [PATCH 2/2] cdx: Explicitly include correct DT includes, again Agarwal, Nikhil
2023-12-12 4:40 ` [PATCH 1/2] cdx: Enable COMPILE_TEST Agarwal, Nikhil
2023-12-12 14:26 ` Rob Herring
2023-12-18 4:39 ` Agarwal, Nikhil
2023-12-15 16:09 ` Greg Kroah-Hartman
2023-12-15 16:10 ` Greg Kroah-Hartman
2023-12-21 6:42 ` Gangurde, Abhijit
2023-12-21 8:07 ` Greg Kroah-Hartman
2023-12-21 8:40 ` Gangurde, Abhijit
2023-12-21 8:46 ` Greg Kroah-Hartman
2023-12-18 4:40 ` Agarwal, Nikhil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207163128.2707993-2-robh@kernel.org \
--to=robh@kernel.org \
--cc=abhijit.gangurde@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikhil.agarwal@amd.com \
--cc=nipun.gupta@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox