From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Théo Lebrun" <theo.lebrun@bootlin.com>
Cc: "Russell King" <linux@armlinux.org.uk>,
"Jiri Slaby" <jirislaby@kernel.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
"Linus Walleij" <linus.walleij@linaro.org>,
"Grégory Clement" <gregory.clement@bootlin.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH v5 2/9] tty: serial: amba: Use linux/{bits,bitfield}.h macros
Date: Thu, 7 Dec 2023 10:37:38 +0900 [thread overview]
Message-ID: <2023120742-argue-slighting-6120@gregkh> (raw)
In-Reply-To: <20231130-mbly-uart-v5-2-6566703a04b5@bootlin.com>
On Thu, Nov 30, 2023 at 03:07:14PM +0100, Théo Lebrun wrote:
> The driver uses bit shifts and hexadecimal expressions to declare
> constants. Replace that with the BIT(), GENMASK() & FIELD_PREP_CONST()
> macros to clarify intent.
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
> ---
> include/linux/amba/serial.h | 248 +++++++++++++++++++++++---------------------
> 1 file changed, 127 insertions(+), 121 deletions(-)
As 0-day had a problem with this patch, I've applied only patch 1 of
this series. Can you fix it up and rebase and resend the rest again
(while adding the collected reviewed-by that some patches in this series
had)?
thanks,
greg k-h
next prev parent reply other threads:[~2023-12-07 6:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 14:07 [PATCH v5 0/9] Cleanup AMBA PL011 driver Théo Lebrun
2023-11-30 14:07 ` [PATCH v5 1/9] tty: serial: amba: cleanup whitespace Théo Lebrun
2023-11-30 14:07 ` [PATCH v5 2/9] tty: serial: amba: Use linux/{bits,bitfield}.h macros Théo Lebrun
2023-12-06 3:27 ` kernel test robot
2023-12-07 1:37 ` Greg Kroah-Hartman [this message]
2023-12-07 9:32 ` Théo Lebrun
2023-12-07 9:56 ` Ilpo Järvinen
2023-12-07 17:58 ` Théo Lebrun
2023-12-09 14:06 ` kernel test robot
2023-11-30 14:07 ` [PATCH v5 3/9] tty: serial: amba-pl011: fix whitespace formatting Théo Lebrun
2023-11-30 14:07 ` [PATCH v5 4/9] tty: serial: amba-pl011: replace TIOCMBIT macros by static functions Théo Lebrun
2023-11-30 14:07 ` [PATCH v5 5/9] tty: serial: amba-pl011: avoid quoted string split across lines Théo Lebrun
2023-11-30 14:19 ` Ilpo Järvinen
2023-12-04 10:01 ` Linus Walleij
2023-12-09 14:43 ` Christophe JAILLET
2023-11-30 14:07 ` [PATCH v5 6/9] tty: serial: amba-pl011: fix formatting of conditions Théo Lebrun
2023-12-04 10:02 ` Linus Walleij
2023-11-30 14:07 ` [PATCH v5 7/9] tty: serial: amba-pl011: fix miscellaneous checkpatch warnings Théo Lebrun
2023-12-04 10:02 ` Linus Walleij
2023-11-30 14:07 ` [PATCH v5 8/9] tty: serial: amba-pl011: unindent pl011_console_get_options function body Théo Lebrun
2023-11-30 14:07 ` [PATCH v5 9/9] tty: serial: amba-pl011: factor QDF2400 SoC erratum 44 out of probe Théo Lebrun
2023-12-04 10:01 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023120742-argue-slighting-6120@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=alexandre.belloni@bootlin.com \
--cc=gregory.clement@bootlin.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=tawfik.bayouk@mobileye.com \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox