From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1248C4167B for ; Thu, 7 Dec 2023 06:51:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378035AbjLGGvh (ORCPT ); Thu, 7 Dec 2023 01:51:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377837AbjLGGvQ (ORCPT ); Thu, 7 Dec 2023 01:51:16 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6699B19AD for ; Wed, 6 Dec 2023 22:50:58 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C665C433CC; Thu, 7 Dec 2023 06:50:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1701931857; bh=5rq84evr5Sp4/RH4eXvLAxgnsQiE23jaVtXpmghA1G0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CcR4zYOrTjlo6Y9j0vouEKHP+t3UfzxX0klqYQd02P6/nycMBXSx4jDA1ys1O7l// jEn30fvBRo2lOihnjQ5AG2LzYlSBB48wiMoO3w1eNt16E9Rc2GwEnS7F6VniJeUYu+ pA5Nr5e/CozwpXpbYkitpAYnB67qETBIb7FhElCM= Date: Thu, 7 Dec 2023 10:45:48 +0900 From: Greg KH To: Hugo Villeneuve Cc: jirislaby@kernel.org, hvilleneuve@dimonoff.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, stable@vger.kernel.org, Andy Shevchenko Subject: Re: [PATCH 1/7] serial: sc16is7xx: fix snprintf format specifier in sc16is7xx_regmap_name() Message-ID: <2023120748-macaroni-gaining-335f@gregkh> References: <20231130191050.3165862-1-hugo@hugovil.com> <20231130191050.3165862-2-hugo@hugovil.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231130191050.3165862-2-hugo@hugovil.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 30, 2023 at 02:10:43PM -0500, Hugo Villeneuve wrote: > From: Hugo Villeneuve > > Change snprint format specifier from %d to %u since port_id is unsigned. > > Fixes: 3837a0379533 ("serial: sc16is7xx: improve regmap debugfs by using one regmap per port") > Cc: stable@vger.kernel.org # 6.1.x: 3837a03 serial: sc16is7xx: improve regmap debugfs by using one regmap per port > Suggested-by: Andy Shevchenko > Signed-off-by: Hugo Villeneuve > --- > I did not originally add a "Cc: stable" tag for commit 3837a0379533 ("serial: sc16is7xx: improve regmap debugfs by using one regmap per port") > as it was intended only to improve debugging using debugfs. But > since then, I have been able to confirm that it also fixes a long standing > bug in our system where the Tx interrupt are no longer enabled at some > point when transmitting large RS-485 paquets (> 64 bytes, which is the size > of the FIFO). I have been investigating why, but so far I haven't found the > exact cause, altough I suspect it has something to do with regmap caching. > Therefore, I have added it as a prerequisite for this patch so that it is > automatically added to the stable kernels. As you are splitting fixes from non-fixes in this series, please resend this as 2 different series, one that I can apply now to my tty-linus branch to get merged for 6.7-final, and one that can go into tty-next for 6.8-rc1. Mixing them up here just ensures that they all would get applied to tty-next. thanks, greg k-h