Re: [RESEND PATCH] tty: serial: 8250: Fix MOXA RS422/RS485 PCIe boards not work by default

Greg Kroah-Hartman
2023-12-07T06:51:13Z

On Fri, Dec 01, 2023 at 05:02:33PM +0800, Crescent CY Hsieh wrote:
> On Fri, Dec 01, 2023 at 08:27:05AM +0000, Greg Kroah-Hartman wrote:
> > On Fri, Dec 01, 2023 at 03:40:55PM +0800, Crescent CY Hsieh wrote:
> > > MOXA PCIe RS422/RS485 boards will not function by default because of the
> > > initial default serial interface of all MOXA PCIe boards is set to
> > > RS232.
> > >
> > > This patch fixes the problem above by setting the initial default serial
> > > interface to RS422 for those MOXA RS422/RS485 PCIe boards.
> > >
> > > Signed-off-by: Crescent CY Hsieh <crescentcy.hsieh@moxa.com>
> > > Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> > > ---
> > > drivers/tty/serial/8250/8250_pci.c | 58 +++++++++++++++++++++++++++++-
> > > 1 file changed, 57 insertions(+), 1 deletion(-)
> >
> > Why is this a RESEND? What happened to the first attempt, did I miss it
> > somewhere?
>
> This RESEND patch is the first patch of this patch series [1], Jiri
> reviewed the first patch and suggested to split the second patch, so I
> split the second patch and sent it as a new patch.
>
> However, the first patch seems to be overlooked, so I resend it.
>
> [1] https://lore.kernel.org/all/20231027062440.7749-1-crescentcy.hsieh@moxa.com/

Looks like 0-day had a problem with it, please fix that up and resend a
new version.

thanks,

greg k-h