From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73067C4167B for ; Fri, 8 Dec 2023 20:59:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1574751AbjLHU72 (ORCPT ); Fri, 8 Dec 2023 15:59:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230358AbjLHU7Z (ORCPT ); Fri, 8 Dec 2023 15:59:25 -0500 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEFB2173B for ; Fri, 8 Dec 2023 12:59:30 -0800 (PST) Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-6cc02e77a9cso2000235b3a.0 for ; Fri, 08 Dec 2023 12:59:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1702069170; x=1702673970; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=//d0ewCiSoi9Ah/KJneNBRTQUj92KNYNsxOQ0uEtAso=; b=G1f6n//vyrIqVRqCttdzzTwrVVlx1CyxGpC8ZKZFjfmrg0zF3V1JK2nYGmqsQibT04 KpIiZOK+hzXbl/GNGG6BqaVgQD+Y/r2eitgyvrRWtEUFhPjh7k7IjJlWyhvDASUvtbwN lTr0MFLVck25i0w7WuiiQvWptUkQbaBj9Y+KQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702069170; x=1702673970; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=//d0ewCiSoi9Ah/KJneNBRTQUj92KNYNsxOQ0uEtAso=; b=idhypa5RN4hO7tfq1CgfcFR4TplnlOMSLzwZXxumswZcMYHoJvsFjgSuMdEFjvWyuA NzmUT1QlapSGvitY/dEzkp4EpuorgkbsdcEtot7JDmwCEQo6jt1NvYTisZLn/aGy6Riu bKr1lNCG+8upC+mo85neF8Z2JSy9N2FqvVDABfwlh78HqBWEgI6ZB2f8X2NpQJ1tUcNT T0Ghl22Eic28r0nZJkEMVOJJeBhm7RJMATk/WQgxQcQe/HTRd0erSwWUrJgplp2Y9EEK kg7GRXFMLxwcFaw5yuVGE7Ap+u0oicvpmRdQQyXijlUB5VsJcS1AowUBIhHhh5UmDpmC kdng== X-Gm-Message-State: AOJu0YxdZFYpLBqMIwXNwoF8pF+ac8qsS7cnmetwKLuO7tqFICMS2PiX GKQjZwvlZwahwSm1rgv4iTUHMA== X-Google-Smtp-Source: AGHT+IFxIA2efn2xc4OHP+ACLNti6gZCsvmwQThrbf9iz+l1OK9yJwseOO8PZQqe6Vj8f7ZclAEtIA== X-Received: by 2002:a05:6a20:1609:b0:18f:b21:9883 with SMTP id l9-20020a056a20160900b0018f0b219883mr801607pzj.32.1702069170403; Fri, 08 Dec 2023 12:59:30 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id s16-20020a62e710000000b006ce3bf7acc7sm1997867pfh.113.2023.12.08.12.59.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 12:59:29 -0800 (PST) Date: Fri, 8 Dec 2023 12:59:29 -0800 From: Kees Cook To: Christophe JAILLET Cc: Bryan Tan , Vishnu Dasa , VMware PV-Drivers Reviewers , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 2/2] VMCI: Remove VMCI_HANDLE_ARRAY_HEADER_SIZE and VMCI_HANDLE_ARRAY_MAX_CAPACITY Message-ID: <202312081259.23AA2CB4@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 08, 2023 at 09:46:10PM +0100, Christophe JAILLET wrote: > Remove VMCI_HANDLE_ARRAY_HEADER_SIZE and VMCI_HANDLE_ARRAY_MAX_CAPACITY > that are unused. > > Suggested-by: Kees Cook > Signed-off-by: Christophe JAILLET Yes, better to just use proper sizeof(). :) Reviewed-by: Kees Cook -- Kees Cook