Re: [PATCH 1/2] xhci: Introduce "disable-usb3" DT property/quirk

Krzysztof Kozlowski
2023-12-09T13:53:47Z

On 08/12/2023 22:04, Sam Edwards wrote:
> Some systems may have xHCI controllers that enumerate USB 3.0 ports, but
> these ports nevertheless cannot be used. Perhaps enabling them triggers a
> hardware bug, or perhaps they simply aren't connected and it would be
> confusing to the user to see an unusable USB 3.0 rhub show up -- whatever
> the case may be, it's reasonable to want to disable these ports.
>
> Add a DT property (and associated quirk) to the xHCI driver that skips
> over (i.e. ignores and doesn't initialize) any USB 3.0 ports discovered
> during driver initialization.
>
> Signed-off-by: Sam Edwards <CFSworks@gmail.com>
> ---
> Documentation/devicetree/bindings/usb/usb-xhci.yaml | 4 ++++

Bindings are always separate patches.

Please do not sneak in properties without DT review.

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.

Best regards,
Krzysztof