From: kan.liang@linux.intel.com
To: acme@kernel.org, irogers@google.com
Cc: namhyung@kernel.org, mark.rutland@arm.com, maz@kernel.org,
marcan@marcan.st, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org,
Kan Liang <kan.liang@linux.intel.com>
Subject: [PATCH] perf top: Use evsel's cpus to replace user_requested_cpus
Date: Fri, 8 Dec 2023 13:08:55 -0800 [thread overview]
Message-ID: <20231208210855.407580-1-kan.liang@linux.intel.com> (raw)
From: Kan Liang <kan.liang@linux.intel.com>
perf top errors out on a hybrid machine
$perf top
Error:
The cycles:P event is not supported.
The user_requested_cpus may contain CPUs that are invalid for a hybrid
PMU. It causes perf_event_open to fail.
The commit ef91871c960e ("perf evlist: Propagate user CPU maps
intersecting core PMU maps") already intersect the requested CPU map
with the CPU map of the PMU. Use the evsel's cpus to replace
user_requested_cpus.
The evlist's threads is also propagated to evsel's threads in
__perf_evlist__propagate_maps(). Replace it as well.
Reported-by: Arnaldo Carvalho de Melo <acme@kernel.org>
Closes: https://lore.kernel.org/linux-perf-users/ZXNnDrGKXbEELMXV@kernel.org/
Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
---
tools/perf/builtin-top.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index ea8c7eca5eee..cce9350177e2 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -1027,8 +1027,8 @@ static int perf_top__start_counters(struct perf_top *top)
evlist__for_each_entry(evlist, counter) {
try_again:
- if (evsel__open(counter, top->evlist->core.user_requested_cpus,
- top->evlist->core.threads) < 0) {
+ if (evsel__open(counter, counter->core.cpus,
+ counter->core.threads) < 0) {
/*
* Specially handle overwrite fall back.
--
2.35.1
next reply other threads:[~2023-12-08 21:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 21:08 kan.liang [this message]
2023-12-11 21:13 ` [PATCH] perf top: Use evsel's cpus to replace user_requested_cpus Arnaldo Carvalho de Melo
2023-12-12 15:56 ` Liang, Kan
2023-12-12 16:58 ` Arnaldo Carvalho de Melo
2023-12-12 17:23 ` Namhyung Kim
2023-12-12 18:00 ` Ian Rogers
2023-12-12 18:31 ` Mark Rutland
2023-12-12 18:49 ` Namhyung Kim
2023-12-12 19:22 ` Liang, Kan
2023-12-13 12:05 ` Mark Rutland
2023-12-12 19:26 ` Ian Rogers
2023-12-15 15:36 ` Arnaldo Carvalho de Melo
2023-12-15 16:51 ` Mark Rutland
2023-12-15 17:49 ` Arnaldo Carvalho de Melo
2024-01-05 12:31 ` Mark Rutland
2023-12-15 17:59 ` Liang, Kan
2023-12-15 18:26 ` Arnaldo Carvalho de Melo
2023-12-15 18:53 ` Liang, Kan
2023-12-18 20:23 ` Arnaldo Carvalho de Melo
2023-12-18 21:07 ` Liang, Kan
2023-12-12 0:02 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231208210855.407580-1-kan.liang@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=acme@kernel.org \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox