From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F6CDC4167B for ; Fri, 8 Dec 2023 22:10:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1574895AbjLHWKY (ORCPT ); Fri, 8 Dec 2023 17:10:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1574886AbjLHWKV (ORCPT ); Fri, 8 Dec 2023 17:10:21 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 892B0171D; Fri, 8 Dec 2023 14:10:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/0Qz43yXWHKRpnVXenO5RhbNzM7+gVncZQ63SMwE3i4=; b=FGvjnfZ7+Por6qLX7oGRUbZTeQ I0DhdI59LFdS83KUNARfpVoB+NROGqZhSY3HVXg+Y+Rk5vz82vI++nvPojoocbk1Y5foyoi2CsFFk m1nr7LWznGR+iTy0g+3uD3GMwKRciZ16K8R+/iSMbk0x3FBdU8o0NKH9PEzPl/p6/cYh/t3O1PLcg d0Y2znNuzkjlkSqx4MBusJPC3X/nUn0pWmcJUTUhUtNlsA5TTkEr3qrLJfq/m3D06BD5xtJ0XoZXY nXrMxljNFpzAr10nWbH7zGfxOeNK8ax6cLAgGb1tx4fTva0JyTouSkV9HlNDWd/Ggq+3yHez0eDnS 7yuK3HfA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1rBj2u-006fJt-EM; Fri, 08 Dec 2023 22:10:08 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 76E993003F0; Fri, 8 Dec 2023 23:10:07 +0100 (CET) Date: Fri, 8 Dec 2023 23:10:07 +0100 From: Peter Zijlstra To: John Hubbard Cc: David Hildenbrand , Linus Torvalds , Andrew Morton , Peter Xu , Shuah Khan , Nathan Chancellor , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, LKML , Muhammad Usama Anjum , Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [PATCH v3 11/11] selftests: error out if kernel header files are not yet built Message-ID: <20231208221007.GO28727@noisy.programming.kicks-ass.net> References: <20230606071637.267103-1-jhubbard@nvidia.com> <20230606071637.267103-12-jhubbard@nvidia.com> <20231103121652.GA6217@noisy.programming.kicks-ass.net> <20231208151401.GG28727@noisy.programming.kicks-ass.net> <990feea2-c7a8-4cd9-8a6a-bc4bc1c2ffab@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 08, 2023 at 12:29:37PM -0800, John Hubbard wrote: > I don't have a strong opinion about how this should be done, and in > fact I believed at the time that I was bringing the system into > compliance with what everyone wanted here. :) > > There seem to be two conflicting visions: > > a) The way it was (much) earlier: use ifdefs and defines to get by > without the latest kernel headers, or > > b) Requiring recent kernel headers to build the various selftests. > > Shuah, Peter, others: can we choose a direction please? Either > way will work, and I personally don't care which one we choose. So as David already argued, the current thing does not in fact help with b. You just have to install once and the error goes away, then carry that tree for a year and you're running old crap again. My biggest beef with the whole thing is that I simply do not want to use 'make headers', it doesn't work for me. I have a ton of output directories and I don't care to build tools into the output dirs, in fact some of them flat out refuse to work that way (bpf comes to mind).