[PATCH 1/1] soc: qcom: Fix compile error caused by uncorrectable definition of TRACE_INCLUDE_PATH

[PATCH 1/1] soc: qcom: Fix compile error caused by uncorrectable definition of TRACE_INCLUDE_PATH

['Guanjun']

From: Guanjun <guanjun@linux.alibaba.com>

Compiler reports the error message when compiling the file drivers/soc/qcom/pmic_pdcharger_ulog.c:
  - ./include/trace/define_trace.h:95:42: fatal error: ./pmic_pdcharger_ulog.h: No such file or directory
      95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)

TRACE_INCLUDE_PATH shoule be relative to the path include/trace/define_trace.h, not
the file including it. Fix it.

Fixes: 086fdb48bc65d(soc: qcom: add ADSP PDCharger ULOG driver)
Signed-off-by: Guanjun <guanjun@linux.alibaba.com>
---
 drivers/soc/qcom/pmic_pdcharger_ulog.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/pmic_pdcharger_ulog.h b/drivers/soc/qcom/pmic_pdcharger_ulog.h
index 9d5d9af4fbe4..3ac994d160bd 100644
--- a/drivers/soc/qcom/pmic_pdcharger_ulog.h
+++ b/drivers/soc/qcom/pmic_pdcharger_ulog.h
@@ -28,7 +28,7 @@ TRACE_EVENT(pmic_pdcharger_ulog_msg,
 /* This part must be outside protection */
 
 #undef TRACE_INCLUDE_PATH
-#define TRACE_INCLUDE_PATH .
+#define TRACE_INCLUDE_PATH ../../../drivers/soc/qcom/
 
 #undef TRACE_INCLUDE_FILE
 #define TRACE_INCLUDE_FILE pmic_pdcharger_ulog
-- 
2.39.3

Re: [PATCH 1/1] soc: qcom: Fix compile error caused by uncorrectable definition of TRACE_INCLUDE_PATH

[Andrew Halaney]

On Sat, Dec 09, 2023 at 03:47:16PM +0800, 'Guanjun' wrote:
> From: Guanjun <guanjun@linux.alibaba.com>
> 
> Compiler reports the error message when compiling the file drivers/soc/qcom/pmic_pdcharger_ulog.c:
>   - ./include/trace/define_trace.h:95:42: fatal error: ./pmic_pdcharger_ulog.h: No such file or directory
>       95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
> 
> TRACE_INCLUDE_PATH shoule be relative to the path include/trace/define_trace.h, not
> the file including it. Fix it.
> 
> Fixes: 086fdb48bc65d(soc: qcom: add ADSP PDCharger ULOG driver)
> Signed-off-by: Guanjun <guanjun@linux.alibaba.com>

For what it is worth I sent a similar patch (which handled this by using
the CFLAG -I recommendation) over here about a week ago:

    https://lore.kernel.org/linux-arm-msm/20231205-pmicpdcharger-ulog-fixups-v1-1-71c95162cb84@redhat.com/

I keep disabling this driver locally when developing (or picking up that
patch) until something gets scooped up.

> ---
>  drivers/soc/qcom/pmic_pdcharger_ulog.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/pmic_pdcharger_ulog.h b/drivers/soc/qcom/pmic_pdcharger_ulog.h
> index 9d5d9af4fbe4..3ac994d160bd 100644
> --- a/drivers/soc/qcom/pmic_pdcharger_ulog.h
> +++ b/drivers/soc/qcom/pmic_pdcharger_ulog.h
> @@ -28,7 +28,7 @@ TRACE_EVENT(pmic_pdcharger_ulog_msg,
>  /* This part must be outside protection */
>  
>  #undef TRACE_INCLUDE_PATH
> -#define TRACE_INCLUDE_PATH .
> +#define TRACE_INCLUDE_PATH ../../../drivers/soc/qcom/
>  
>  #undef TRACE_INCLUDE_FILE
>  #define TRACE_INCLUDE_FILE pmic_pdcharger_ulog
> -- 
> 2.39.3
> 
> 

Re: [PATCH 1/1] soc: qcom: Fix compile error caused by uncorrectable definition of TRACE_INCLUDE_PATH

[guanjun]

> 2023年12月12日 下午10:44，Andrew Halaney <ahalaney@redhat.com> 写道：
> 
> On Sat, Dec 09, 2023 at 03:47:16PM +0800, 'Guanjun' wrote:
>> From: Guanjun <guanjun@linux.alibaba.com>
>> 
>> Compiler reports the error message when compiling the file drivers/soc/qcom/pmic_pdcharger_ulog.c:
>>  - ./include/trace/define_trace.h:95:42: fatal error: ./pmic_pdcharger_ulog.h: No such file or directory
>>      95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
>> 
>> TRACE_INCLUDE_PATH shoule be relative to the path include/trace/define_trace.h, not
>> the file including it. Fix it.
>> 
>> Fixes: 086fdb48bc65d(soc: qcom: add ADSP PDCharger ULOG driver)
>> Signed-off-by: Guanjun <guanjun@linux.alibaba.com>
> 
> For what it is worth I sent a similar patch (which handled this by using
> the CFLAG -I recommendation) over here about a week ago:
> 
>    https://lore.kernel.org/linux-arm-msm/20231205-pmicpdcharger-ulog-fixups-v1-1-71c95162cb84@redhat.com/

Sorry. I didn’t check you have already sent the fixed patch. Please ignore this email

> 
> I keep disabling this driver locally when developing (or picking up that
> patch) until something gets scooped up.
> 
>> ---
>> drivers/soc/qcom/pmic_pdcharger_ulog.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/soc/qcom/pmic_pdcharger_ulog.h b/drivers/soc/qcom/pmic_pdcharger_ulog.h
>> index 9d5d9af4fbe4..3ac994d160bd 100644
>> --- a/drivers/soc/qcom/pmic_pdcharger_ulog.h
>> +++ b/drivers/soc/qcom/pmic_pdcharger_ulog.h
>> @@ -28,7 +28,7 @@ TRACE_EVENT(pmic_pdcharger_ulog_msg,
>> /* This part must be outside protection */
>> 
>> #undef TRACE_INCLUDE_PATH
>> -#define TRACE_INCLUDE_PATH .
>> +#define TRACE_INCLUDE_PATH ../../../drivers/soc/qcom/
>> 
>> #undef TRACE_INCLUDE_FILE
>> #define TRACE_INCLUDE_FILE pmic_pdcharger_ulog
>> -- 
>> 2.39.3
>> 
>>