From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Armin Wolf <W_Armin@gmx.de>, Guenter Roeck <linux@roeck-us.net>,
Sasha Levin <sashal@kernel.org>,
wilken.gottwalt@posteo.net, jdelvare@suse.com,
linux-hwmon@vger.kernel.org
Subject: [PATCH AUTOSEL 6.1 28/29] hwmon: (corsair-psu) Fix probe when built-in
Date: Mon, 11 Dec 2023 08:54:12 -0500 [thread overview]
Message-ID: <20231211135457.381397-28-sashal@kernel.org> (raw)
In-Reply-To: <20231211135457.381397-1-sashal@kernel.org>
From: Armin Wolf <W_Armin@gmx.de>
[ Upstream commit 307004e8b254ad28e150b63f299ab9caa4bc7c3e ]
It seems that when the driver is built-in, the HID bus is
initialized after the driver is loaded, which whould cause
module_hid_driver() to fail.
Fix this by registering the driver after the HID bus using
late_initcall() in accordance with other hwmon HID drivers.
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Link: https://lore.kernel.org/r/20231207210723.222552-1-W_Armin@gmx.de
[groeck: Dropped "compile tested" comment; the patch has been tested
but the tester did not provide a Tested-by: tag]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/hwmon/corsair-psu.c | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/hwmon/corsair-psu.c b/drivers/hwmon/corsair-psu.c
index 2210aa62e3d06..ec7f27a6ce016 100644
--- a/drivers/hwmon/corsair-psu.c
+++ b/drivers/hwmon/corsair-psu.c
@@ -837,7 +837,23 @@ static struct hid_driver corsairpsu_driver = {
.reset_resume = corsairpsu_resume,
#endif
};
-module_hid_driver(corsairpsu_driver);
+
+static int __init corsair_init(void)
+{
+ return hid_register_driver(&corsairpsu_driver);
+}
+
+static void __exit corsair_exit(void)
+{
+ hid_unregister_driver(&corsairpsu_driver);
+}
+
+/*
+ * With module_init() the driver would load before the HID bus when
+ * built-in, so use late_initcall() instead.
+ */
+late_initcall(corsair_init);
+module_exit(corsair_exit);
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Wilken Gottwalt <wilken.gottwalt@posteo.net>");
--
2.42.0
next prev parent reply other threads:[~2023-12-11 13:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 13:53 [PATCH AUTOSEL 6.1 01/29] hwtracing: hisi_ptt: Handle the interrupt in hardirq context Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 02/29] hwtracing: hisi_ptt: Don't try to attach a task Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 03/29] ASoC: wm8974: Correct boost mixer inputs Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 04/29] arm64: dts: rockchip: fix rk356x pcie msg interrupt name Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 05/29] ASoC: Intel: Skylake: Fix mem leak in few functions Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 06/29] ASoC: nau8822: Fix incorrect type in assignment and cast to restricted __be16 Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 07/29] ASoC: Intel: Skylake: mem leak in skl register function Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 08/29] ASoC: cs43130: Fix the position of const qualifier Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 09/29] ASoC: cs43130: Fix incorrect frame delay configuration Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 10/29] ASoC: rt5650: add mutex to avoid the jack detection failure Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 11/29] ASoC: SOF: mediatek: mt8186: Add Google Steelix topology compatible Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 12/29] ASoC: Intel: skl_hda_dsp_generic: Drop HDMI routes when HDMI is not available Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 13/29] nouveau/tu102: flush all pdbs on vmm flush Sasha Levin
2023-12-11 14:10 ` Timur Tabi
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 14/29] ASoC: amd: yc: Add DMI entry to support System76 Pangolin 13 Sasha Levin
2023-12-11 13:53 ` [PATCH AUTOSEL 6.1 15/29] ASoC: hdac_hda: Conditionally register dais for HDMI and Analog Sasha Levin
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 16/29] net/tg3: fix race condition in tg3_reset_task() Sasha Levin
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 17/29] ASoC: da7219: Support low DC impedance headset Sasha Levin
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 18/29] ASoC: ops: add correct range check for limiting volume Sasha Levin
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 19/29] nvme: introduce helper function to get ctrl state Sasha Levin
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 20/29] nvme: prevent potential spectre v1 gadget Sasha Levin
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 21/29] arm64: dts: rockchip: Fix PCI node addresses on rk3399-gru Sasha Levin
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 22/29] mips/smp: Call rcutree_report_cpu_starting() earlier Sasha Levin
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 23/29] drm/amd/display: Use channel_width = 2 for vram table 3.0 Sasha Levin
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 24/29] drm/amd/display: Add monitor patch for specific eDP Sasha Levin
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 25/29] drm/amdgpu: Add NULL checks for function pointers Sasha Levin
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 26/29] drm/exynos: fix a potential error pointer dereference Sasha Levin
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 27/29] drm/exynos: fix a wrong error checking Sasha Levin
2023-12-11 13:54 ` Sasha Levin [this message]
2023-12-11 13:54 ` [PATCH AUTOSEL 6.1 29/29] LoongArch: Preserve syscall nr across execve() Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231211135457.381397-28-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=W_Armin@gmx.de \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=stable@vger.kernel.org \
--cc=wilken.gottwalt@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox