From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C947DC4167B for ; Mon, 11 Dec 2023 14:05:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344291AbjLKOFL (ORCPT ); Mon, 11 Dec 2023 09:05:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344199AbjLKOEO (ORCPT ); Mon, 11 Dec 2023 09:04:14 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A53135B6 for ; Mon, 11 Dec 2023 06:02:46 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E8F4C433C9; Mon, 11 Dec 2023 14:02:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702303365; bh=W0dgYjgyezEIWv6mifXWfWGlfmcw5yAAe0M93lsc+24=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RpzgFko5YP2lxus8lYeUTt+hjwV5feJwNdEzAfFufiKtBwasccaZb49z4Gx2hLm9u m4yT1ljHnx79K69H1c0j32NDs6Nn1BfQPWdOS3b6uUhizCLeqx+Rx2lZ6KVrtlO/oj 3kSyraF7GCKjvG+ZrZLZfJW4sqd8JRAFexnK0EAZhv1ON8CUawON/G1/F2jGz5MSwR 8SC6YkIWv9L5XLKKnuC3KcYn+EwSzaOB5xt591lNTQKoxJT9tRX1u95xsq0RrocsG1 5SAyKGcA69HVWUKHoc+PqDltIWNzepJu7146El7eIgrFBf6WVnbD/OPrm4G0R0bRHo HqGROUogD7coA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Keith Busch , Sagi Grimberg , Sasha Levin , linux-nvme@lists.infradead.org Subject: [PATCH AUTOSEL 5.4 10/12] nvme: introduce helper function to get ctrl state Date: Mon, 11 Dec 2023 09:02:03 -0500 Message-ID: <20231211140219.392379-10-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231211140219.392379-1-sashal@kernel.org> References: <20231211140219.392379-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.263 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Keith Busch [ Upstream commit 5c687c287c46fadb14644091823298875a5216aa ] The controller state is typically written by another CPU, so reading it should ensure no optimizations are taken. This is a repeated pattern in the driver, so start with adding a convenience function that returns the controller state with READ_ONCE(). Reviewed-by: Sagi Grimberg Signed-off-by: Keith Busch Signed-off-by: Sasha Levin --- drivers/nvme/host/nvme.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h index 17c0d6ae3eeeb..c492d7d323987 100644 --- a/drivers/nvme/host/nvme.h +++ b/drivers/nvme/host/nvme.h @@ -292,6 +292,11 @@ struct nvme_ctrl { struct nvme_fault_inject fault_inject; }; +static inline enum nvme_ctrl_state nvme_ctrl_state(struct nvme_ctrl *ctrl) +{ + return READ_ONCE(ctrl->state); +} + enum nvme_iopolicy { NVME_IOPOLICY_NUMA, NVME_IOPOLICY_RR, -- 2.42.0