Re: [PATCH v1 01/39] mm/rmap: rename hugepage_add* to hugetlb_add*

Matthew Wilcox
2023-12-11T16:24:23Z

On Mon, Dec 11, 2023 at 04:56:14PM +0100, David Hildenbrand wrote:
> Let's just call it "hugetlb_".
>
> Yes, it's all already inconsistent and confusing because we have a lot
> of "hugepage_" functions for legacy reasons. But "hugetlb" cannot possibly
> be confused with transparent huge pages, and it matches "hugetlb.c" and
> "folio_test_hugetlb()". So let's minimize confusion in rmap code.
>
> Reviewed-by: Muchun Song <songmuchun@bytedance.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>

Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>