[PATCH v2] riscv: remove unused header

[PATCH v2] riscv: remove unused header

[tanzirh]

arch/riscv/kernel/sys_riscv.c builds without using anything
from asm-generic/mman-common.h. There seems to be no reason
to include this file.

Signed-off-by: Tanzir Hasan <tanzirh@google.com>
---

---
Changes in v2:
- Changed name to riscv: remove unused header
- Link to v1: https://lore.kernel.org/r/20231211-removeasmgeneric-v1-1-a0274e802789@google.com
---
 arch/riscv/kernel/sys_riscv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/riscv/kernel/sys_riscv.c b/arch/riscv/kernel/sys_riscv.c
index a2ca5b7756a5..ebcaf386ea62 100644
--- a/arch/riscv/kernel/sys_riscv.c
+++ b/arch/riscv/kernel/sys_riscv.c
@@ -14,7 +14,6 @@
 #include <asm/switch_to.h>
 #include <asm/uaccess.h>
 #include <asm/unistd.h>
-#include <asm-generic/mman-common.h>
 #include <vdso/vsyscall.h>
 
 static long riscv_sys_mmap(unsigned long addr, unsigned long len,

---
base-commit: a39b6ac3781d46ba18193c9dbb2110f31e9bffe9
change-id: 20231211-removeasmgeneric-f6be13a42b6b

Best regards,
-- 
Tanzir Hasan <tanzirh@google.com>

Re: [PATCH v2] riscv: remove unused header

[Nick Desaulniers]

On Mon, Dec 11, 2023 at 4:20 PM <tanzirh@google.com> wrote:
>
> arch/riscv/kernel/sys_riscv.c builds without using anything
> from asm-generic/mman-common.h. There seems to be no reason
> to include this file.
>
> Signed-off-by: Tanzir Hasan <tanzirh@google.com>

Thanks for the patch!

Fixes: 9e2e6042a7ec ("riscv: Allow PROT_WRITE-only mmap()")
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: Nick Desaulniers <ndesaulniers@google.com>

> ---
>
> ---

You're still getting funky extra `---`; let's take a look later at how
you're using `b4` together offline.  It's not a problem for me to
apply the patch, but something still isn't quite right. (Do not send a
v3 over this)

> Changes in v2:
> - Changed name to riscv: remove unused header
> - Link to v1: https://lore.kernel.org/r/20231211-removeasmgeneric-v1-1-a0274e802789@google.com
> ---
>  arch/riscv/kernel/sys_riscv.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/sys_riscv.c b/arch/riscv/kernel/sys_riscv.c
> index a2ca5b7756a5..ebcaf386ea62 100644
> --- a/arch/riscv/kernel/sys_riscv.c
> +++ b/arch/riscv/kernel/sys_riscv.c
> @@ -14,7 +14,6 @@
>  #include <asm/switch_to.h>
>  #include <asm/uaccess.h>
>  #include <asm/unistd.h>
> -#include <asm-generic/mman-common.h>
>  #include <vdso/vsyscall.h>
>
>  static long riscv_sys_mmap(unsigned long addr, unsigned long len,
>
> ---
> base-commit: a39b6ac3781d46ba18193c9dbb2110f31e9bffe9
> change-id: 20231211-removeasmgeneric-f6be13a42b6b
>
> Best regards,
> --
> Tanzir Hasan <tanzirh@google.com>
>


-- 
Thanks,
~Nick Desaulniers

Re: [PATCH v2] riscv: remove unused header

[patchwork-bot+linux-riscv]

Hello:

This patch was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <palmer@rivosinc.com>:

On Tue, 12 Dec 2023 00:20:14 +0000 you wrote:
> arch/riscv/kernel/sys_riscv.c builds without using anything
> from asm-generic/mman-common.h. There seems to be no reason
> to include this file.
> 
> Signed-off-by: Tanzir Hasan <tanzirh@google.com>
> ---
> 
> [...]

Here is the summary with links:
  - [v2] riscv: remove unused header
    https://git.kernel.org/riscv/c/84c3a079ab98

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html