From: David Vernet <void@manifault.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
vschneid@redhat.com, youssefesmat@google.com, joelaf@google.com,
roman.gushchin@linux.dev, yu.c.chen@intel.com,
kprateek.nayak@amd.com, gautham.shenoy@amd.com,
aboorvad@linux.vnet.ibm.com, wuyun.abel@bytedance.com,
tj@kernel.org, kernel-team@meta.com
Subject: [PATCH v4 1/8] sched: Expose move_queued_task() from core.c
Date: Mon, 11 Dec 2023 18:31:34 -0600 [thread overview]
Message-ID: <20231212003141.216236-2-void@manifault.com> (raw)
In-Reply-To: <20231212003141.216236-1-void@manifault.com>
The migrate_task_to() function exposed from kernel/sched/core.c migrates
the current task, which is silently assumed to also be its first
argument, to the specified CPU. The function uses stop_one_cpu() to
migrate the task to the target CPU, which won't work if @p is not the
current task as the stop_one_cpu() callback isn't invoked on remote
CPUs.
While this operation is useful for task_numa_migrate() in fair.c, it
would be useful if move_queued_task() in core.c was given external
linkage, as it actually can be used to migrate any task to a CPU.
A follow-on patch will call move_queued_task() from fair.c when
migrating a task in a shared runqueue to a remote CPU.
Suggested-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: David Vernet <void@manifault.com>
---
kernel/sched/core.c | 4 ++--
kernel/sched/sched.h | 3 +++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index db4be4921e7f..fb6f505d5792 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -2518,8 +2518,8 @@ static inline bool is_cpu_allowed(struct task_struct *p, int cpu)
*
* Returns (locked) new rq. Old rq's lock is released.
*/
-static struct rq *move_queued_task(struct rq *rq, struct rq_flags *rf,
- struct task_struct *p, int new_cpu)
+struct rq *move_queued_task(struct rq *rq, struct rq_flags *rf,
+ struct task_struct *p, int new_cpu)
{
lockdep_assert_rq_held(rq);
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index e58a54bda77d..5afdbd7e2381 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -1787,6 +1787,9 @@ init_numa_balancing(unsigned long clone_flags, struct task_struct *p)
#ifdef CONFIG_SMP
+
+extern struct rq *move_queued_task(struct rq *rq, struct rq_flags *rf,
+ struct task_struct *p, int new_cpu);
static inline void
queue_balance_callback(struct rq *rq,
struct balance_callback *head,
--
2.42.1
next prev parent reply other threads:[~2023-12-12 0:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 0:31 [PATCH v4 0/8] sched: Implement shared runqueue in fair.c David Vernet
2023-12-12 0:31 ` David Vernet [this message]
2023-12-12 0:31 ` [PATCH v4 2/8] sched: Move is_cpu_allowed() into sched.h David Vernet
2023-12-12 0:31 ` [PATCH v4 3/8] sched: Tighten unpinned rq lock window in newidle_balance() David Vernet
2023-12-12 0:31 ` [PATCH v4 4/8] sched: Check cpu_active() earlier " David Vernet
2023-12-12 0:31 ` [PATCH v4 5/8] sched: Enable sched_feat callbacks on enable/disable David Vernet
2023-12-12 0:31 ` [PATCH v4 6/8] sched: Implement shared runqueue in fair.c David Vernet
2023-12-12 0:31 ` [PATCH v4 7/8] sched: Shard per-LLC shared runqueues David Vernet
2023-12-12 0:31 ` [PATCH v4 8/8] sched: Add selftest for SHARED_RUNQ David Vernet
2024-04-17 8:48 ` [PATCH v4 0/8] sched: Implement shared runqueue in fair.c K Prateek Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231212003141.216236-2-void@manifault.com \
--to=void@manifault.com \
--cc=aboorvad@linux.vnet.ibm.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=gautham.shenoy@amd.com \
--cc=joelaf@google.com \
--cc=juri.lelli@redhat.com \
--cc=kernel-team@meta.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=roman.gushchin@linux.dev \
--cc=tj@kernel.org \
--cc=vschneid@redhat.com \
--cc=wuyun.abel@bytedance.com \
--cc=youssefesmat@google.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox