Re: [PATCH v5 21/22] MIPS: generic: Add support for Mobileye EyeQ5

Jiaxun Yang
2023-12-14T09:48:00Z

在2023年12月12日十二月 下午4:34，Gregory CLEMENT写道：
> Introduce support for the MIPS based Mobileye EyeQ5 SoCs.
>
> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
> ---
> arch/mips/configs/generic/board-eyeq5.config | 42 ++++++++++++++++++++
> arch/mips/generic/Kconfig | 15 +++++++
> arch/mips/generic/Platform | 2 +
> arch/mips/generic/board-epm5.its.S | 24 +++++++++++
> 4 files changed, 83 insertions(+)
> create mode 100644 arch/mips/configs/generic/board-eyeq5.config
> create mode 100644 arch/mips/generic/board-epm5.its.S
>
> diff --git a/arch/mips/configs/generic/board-eyeq5.config
> b/arch/mips/configs/generic/board-eyeq5.config
> new file mode 100644
> index 0000000000000..d94e408145389
> --- /dev/null
> +++ b/arch/mips/configs/generic/board-eyeq5.config
> @@ -0,0 +1,42 @@
> +CONFIG_HIGH_RES_TIMERS=y
> +CONFIG_TASKSTATS=y
> +CONFIG_FIT_IMAGE_FDT_EPM5=y
> +CONFIG_BOARD_EYEQ5=y
> +CONFIG_PHYSICAL_START=0xa800000808000000

^ I still think by doing this you are risking overriding starting address
for all other generic systems. make 32r6_defconfig will load config files
of all boards.

Perhaps just provide an eqm5_defconfig will work better?

Thanks.
--
- Jiaxun