Re: [PATCH] clocksource: ep93xx: fix error handling during probe

Daniel Lezcano
2023-12-13T10:28:37Z

On 12/12/2023 22:46, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When the interrupt property fails to be parsed, ep93xx_timer_of_init()
> return code ends up uninitialized:
>
> drivers/clocksource/timer-ep93xx.c:160:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
> if (irq < 0) {
> ^~~~~~~
> drivers/clocksource/timer-ep93xx.c:188:9: note: uninitialized use occurs here
> return ret;
> ^~~
> drivers/clocksource/timer-ep93xx.c:160:2: note: remove the 'if' if its condition is always false
> if (irq < 0) {
> ^~~~~~~~~~~~~~
>
> Simplify this portion to use the normal construct of just checking
> whether a valid interrupt was returned. Note that irq_of_parse_and_map()
> never returns a negative value and no other callers check for that either.
>
> Fixes: c28ca80ba3b5 ("clocksource: ep93xx: Add driver for Cirrus Logic EP93xx")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Applied, thanks

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |