From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Gan, Yi Fang" <yi.fang.gan@intel.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Javier Martinez Canillas <javierm@redhat.com>,
John Stultz <jstultz@google.com>, Jens Axboe <axboe@kernel.dk>,
Andrew Halaney <ahalaney@redhat.com>,
Lobakin@kroah.com, Aleksander <aleksander.lobakin@intel.com>,
Gan@kroah.com, linux-kernel@vger.kernel.org,
Looi Hong Aun <hong.aun.looi@intel.com>,
Voon Weifeng <weifeng.voon@intel.com>,
Song Yoong Siang <yoong.siang.song@intel.com>,
Lai@kroah.com, Peter Jun Ann <peter.jun.ann.lai@intel.com>
Subject: Re: [PATCH net-next 1/1] driver.h: add helper macro for module_exit() boilerplate
Date: Tue, 12 Dec 2023 11:16:30 +0100 [thread overview]
Message-ID: <2023121245-unspoiled-aging-214d@gregkh> (raw)
In-Reply-To: <20231212094352.2263283-1-yi.fang.gan@intel.com>
On Tue, Dec 12, 2023 at 05:43:52PM +0800, Gan, Yi Fang wrote:
> For the modules need a module_init() but don't need to do
> anything special in module_exit() might need to have an empty
> module_exit(). This patch add a new macro module_exit_stub() to
> replace the empty module_exit(). The macro is useful to remove
> the module_exit() boilerplate.
>
> Signed-off-by: Gan, Yi Fang <yi.fang.gan@intel.com>
> ---
> include/linux/device/driver.h | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
Why would we take a macro that no one actually uses?
Please submit this with a user, you all know that this is the case, how
did it pass your internal reviews (hint, I don't think it did...)
thanks,
greg k-h
prev parent reply other threads:[~2023-12-12 10:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 9:43 [PATCH net-next 1/1] driver.h: add helper macro for module_exit() boilerplate Gan, Yi Fang
2023-12-12 10:16 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023121245-unspoiled-aging-214d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Gan@kroah.com \
--cc=Lai@kroah.com \
--cc=Lobakin@kroah.com \
--cc=ahalaney@redhat.com \
--cc=aleksander.lobakin@intel.com \
--cc=axboe@kernel.dk \
--cc=hong.aun.looi@intel.com \
--cc=javierm@redhat.com \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.jun.ann.lai@intel.com \
--cc=rafael@kernel.org \
--cc=weifeng.voon@intel.com \
--cc=yi.fang.gan@intel.com \
--cc=yoong.siang.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox