Re: [PATCH 4.14 00/25] 4.14.333-rc1 review

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Mon, Dec 11, 2023 at 01:46:03PM -0600, Daniel Díaz wrote:
> Hello!
> 
> On 11/12/23 12:20 p. m., Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 4.14.333 release.
> > There are 25 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Wed, 13 Dec 2023 18:19:59 +0000.
> > Anything received after that time might be too late.
> > 
> > The whole patch series can be found in one patch at:
> > 	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.14.333-rc1.gz
> > or in the git tree and branch at:
> > 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.14.y
> > and the diffstat can be found below.
> > 
> > thanks,
> > 
> > greg k-h
> > 
> > -------------
> > Pseudo-Shortlog of commits:
> > 
> > Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >      Linux 4.14.333-rc1
> > 
> [...]
> > 
> > Arnd Bergmann <arnd@arndb.de>
> >      ARM: PL011: Fix DMA support
> [...]
> 
> We see a build problem with this commit (at least) on 4.14:
> -----8<-----
>   /builds/linux/kernel/sched/core.c: In function 'sched_init':
>   /builds/linux/kernel/sched/core.c:5962:30: warning: the comparison will always evaluate as 'false' for the address of 'cpu_isolated_map' will never be NULL [-Waddress]
>    5962 |         if (cpu_isolated_map == NULL)
>         |                              ^~
>   /builds/linux/kernel/sched/core.c:87:15: note: 'cpu_isolated_map' declared here
>      87 | cpumask_var_t cpu_isolated_map;
>         |               ^~~~~~~~~~~~~~~~
>   /builds/linux/drivers/tty/serial/amba-pl011.c: In function 'pl011_dma_tx_refill':
>   /builds/linux/drivers/tty/serial/amba-pl011.c:657:27: error: 'DMA_MAPPING_ERROR' undeclared (first use in this function)
>     657 |         if (dmatx->dma == DMA_MAPPING_ERROR) {
>         |                           ^~~~~~~~~~~~~~~~~
>   /builds/linux/drivers/tty/serial/amba-pl011.c:657:27: note: each undeclared identifier is reported only once for each function it appears in
>   make[4]: *** [/builds/linux/scripts/Makefile.build:329: drivers/tty/serial/amba-pl011.o] Error 1
>   make[4]: Target '__build' not remade because of errors.
> ----->8-----
> 
> Reverting that patch makes the build for arm/u8500_defconfig. We'll continue looking for other things.
> 
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

Thanks, now dropped, I'll push out a -rc2 with this fix.

greg k-h