From: Conor Dooley <conor@kernel.org>
To: Manikanta Guntupalli <manikanta.guntupalli@amd.com>
Cc: git@amd.com, michal.simek@amd.com, gregkh@linuxfoundation.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
jirislaby@kernel.org, linux-arm-kernel@lists.infradead.org,
radhey.shyam.pandey@amd.com, srinivas.goud@amd.com,
shubhrajyoti.datta@amd.com, manion05gk@gmail.com
Subject: Re: [PATCH V5 1/3] dt-bindings: Add reference to rs485.yaml
Date: Wed, 13 Dec 2023 16:02:16 +0000 [thread overview]
Message-ID: <20231213-chief-heroics-fd8ba9dbb653@spud> (raw)
In-Reply-To: <20231213130023.606486-2-manikanta.guntupalli@amd.com>
[-- Attachment #1: Type: text/plain, Size: 1213 bytes --]
On Wed, Dec 13, 2023 at 06:30:21PM +0530, Manikanta Guntupalli wrote:
> Add reference to rs485.yaml
I can see this both from the diff and from $subject. What is missing
here is why.
> Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@amd.com>
> ---
> Changes for V2:
> Modify optional gpio name to xlnx,phy-ctrl-gpios.
> Update commit description.
>
> Changes for V3:
> Modify optional gpio name to rts-gpios.
> Update commit description.
>
> Changes for V4:
> Update rts-gpios description.
>
> Changes for V5:
> Remove rts-gpios description.
> Update commit message and description.
> ---
> Documentation/devicetree/bindings/serial/cdns,uart.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/cdns,uart.yaml b/Documentation/devicetree/bindings/serial/cdns,uart.yaml
> index e35ad1109efc..2129247d7c81 100644
> --- a/Documentation/devicetree/bindings/serial/cdns,uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/cdns,uart.yaml
> @@ -55,6 +55,7 @@ required:
>
> allOf:
> - $ref: serial.yaml#
> + - $ref: rs485.yaml#
> - if:
> properties:
> compatible:
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-12-13 16:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 13:00 [PATCH V5 0/3] Add rs485 support to uartps driver Manikanta Guntupalli
2023-12-13 13:00 ` [PATCH V5 1/3] dt-bindings: Add reference to rs485.yaml Manikanta Guntupalli
2023-12-13 16:02 ` Conor Dooley [this message]
2023-12-13 13:00 ` [PATCH V5 2/3] tty: serial: uartps: Relocate cdns_uart_tx_empty to facilitate rs485 Manikanta Guntupalli
2023-12-13 13:00 ` [PATCH V5 3/3] tty: serial: uartps: Add rs485 support to uartps driver Manikanta Guntupalli
2023-12-13 13:57 ` Ilpo Järvinen
2023-12-14 9:00 ` Lino Sanfilippo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231213-chief-heroics-fd8ba9dbb653@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=manikanta.guntupalli@amd.com \
--cc=manion05gk@gmail.com \
--cc=michal.simek@amd.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=robh+dt@kernel.org \
--cc=shubhrajyoti.datta@amd.com \
--cc=srinivas.goud@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox