The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Jianhua Lu <lujianhua000@gmail.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Banajit Goswami <bgoswami@quicinc.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org, Jianhua Lu <lujianhua000@gmail.com>
Subject: [PATCH v3 2/4] ASoC: qcom: sdm845: switch to qcom_snd_tdm_hw_params helper
Date: Wed, 13 Dec 2023 20:35:54 +0800	[thread overview]
Message-ID: <20231213123556.20469-2-lujianhua000@gmail.com> (raw)
In-Reply-To: <20231213123556.20469-1-lujianhua000@gmail.com>

Use qcom_snd_tdm_hw_params helper to setup TDM ports.

Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
---
Changes in v3:
  1. new patch

 sound/soc/qcom/sdm845.c | 46 +++++++----------------------------------
 1 file changed, 7 insertions(+), 39 deletions(-)

diff --git a/sound/soc/qcom/sdm845.c b/sound/soc/qcom/sdm845.c
index 252a0f0819be..5052c1410723 100644
--- a/sound/soc/qcom/sdm845.c
+++ b/sound/soc/qcom/sdm845.c
@@ -53,8 +53,6 @@ static struct snd_soc_jack_pin sdm845_jack_pins[] = {
 	},
 };
 
-static unsigned int tdm_slot_offset[8] = {0, 4, 8, 12, 16, 20, 24, 28};
-
 static int sdm845_slim_snd_hw_params(struct snd_pcm_substream *substream,
 				     struct snd_pcm_hw_params *params)
 {
@@ -99,10 +97,9 @@ static int sdm845_tdm_snd_hw_params(struct snd_pcm_substream *substream,
 					struct snd_pcm_hw_params *params)
 {
 	struct snd_soc_pcm_runtime *rtd = snd_soc_substream_to_rtd(substream);
-	struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
 	struct snd_soc_dai *codec_dai;
 	int ret = 0, j;
-	int channels, slot_width;
+	int slot_width;
 
 	switch (params_format(params)) {
 	case SNDRV_PCM_FORMAT_S16_LE:
@@ -114,39 +111,11 @@ static int sdm845_tdm_snd_hw_params(struct snd_pcm_substream *substream,
 		return -EINVAL;
 	}
 
-	channels = params_channels(params);
-	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
-		ret = snd_soc_dai_set_tdm_slot(cpu_dai, 0, 0x3,
-				8, slot_width);
-		if (ret < 0) {
-			dev_err(rtd->dev, "%s: failed to set tdm slot, err:%d\n",
-					__func__, ret);
-			goto end;
-		}
-
-		ret = snd_soc_dai_set_channel_map(cpu_dai, 0, NULL,
-				channels, tdm_slot_offset);
-		if (ret < 0) {
-			dev_err(rtd->dev, "%s: failed to set channel map, err:%d\n",
-					__func__, ret);
-			goto end;
-		}
-	} else {
-		ret = snd_soc_dai_set_tdm_slot(cpu_dai, 0xf, 0,
-				8, slot_width);
-		if (ret < 0) {
-			dev_err(rtd->dev, "%s: failed to set tdm slot, err:%d\n",
-					__func__, ret);
-			goto end;
-		}
-
-		ret = snd_soc_dai_set_channel_map(cpu_dai, channels,
-				tdm_slot_offset, 0, NULL);
-		if (ret < 0) {
-			dev_err(rtd->dev, "%s: failed to set channel map, err:%d\n",
-					__func__, ret);
-			goto end;
-		}
+	ret = qcom_snd_tdm_hw_params(substream, params);
+	if (ret < 0) {
+		dev_err(rtd->dev, "%s: failed to setup TDM err:%d\n",
+			__func__, ret);
+		return ret;
 	}
 
 	for_each_rtd_codec_dais(rtd, j, codec_dai) {
@@ -176,8 +145,7 @@ static int sdm845_tdm_snd_hw_params(struct snd_pcm_substream *substream,
 		}
 	}
 
-end:
-	return ret;
+	return 0;
 }
 
 static int sdm845_snd_hw_params(struct snd_pcm_substream *substream,
-- 
2.41.0


  reply	other threads:[~2023-12-13 12:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-13 12:35 [PATCH v3 1/4] ASoC: qcom: common: Add qcom_snd_tdm_hw_params function Jianhua Lu
2023-12-13 12:35 ` Jianhua Lu [this message]
2023-12-13 12:35 ` [PATCH v3 3/4] Asoc: qcom: sdw: Add TDM support Jianhua Lu
2023-12-13 12:35 ` [PATCH v3 4/4] ASoC: qcom: sm8250: Add TERTIARY_TDM_RX_0 support Jianhua Lu
2023-12-14 11:11 ` [PATCH v3 1/4] ASoC: qcom: common: Add qcom_snd_tdm_hw_params function Mark Brown
2023-12-14 15:51   ` Jianhua Lu
2023-12-14 15:56     ` Mark Brown
2023-12-14 16:55       ` Jianhua Lu
2023-12-14 17:04         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231213123556.20469-2-lujianhua000@gmail.com \
    --to=lujianhua000@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=bgoswami@quicinc.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox