From: Lee Jones <lee@kernel.org>
To: Jean Delvare <jdelvare@suse.de>
Cc: Pavel Machek <pavel@ucw.cz>,
linux-leds@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] leds: rgb: Drop obsolete dependency on COMPILE_TEST
Date: Wed, 13 Dec 2023 15:38:38 +0000 [thread overview]
Message-ID: <20231213153838.GM111411@google.com> (raw)
In-Reply-To: <20231202214353.7c02f23c@endymion.delvare>
On Sat, 02 Dec 2023, Jean Delvare wrote:
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Lee Jones <lee@kernel.org>
> ---
> drivers/leds/rgb/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
It's not clear to me what this patch improves.
Going to choose to keep the status quo on this one.
> --- linux-6.6.orig/drivers/leds/rgb/Kconfig
> +++ linux-6.6/drivers/leds/rgb/Kconfig
> @@ -4,7 +4,7 @@ if LEDS_CLASS_MULTICOLOR
>
> config LEDS_GROUP_MULTICOLOR
> tristate "LEDs group multi-color support"
> - depends on OF || COMPILE_TEST
> + depends on OF
> help
> This option enables support for monochrome LEDs that are grouped
> into multicolor LEDs which is useful in the case where LEDs of
>
>
> --
> Jean Delvare
> SUSE L3 Support
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-12-13 15:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-02 20:43 [PATCH] leds: rgb: Drop obsolete dependency on COMPILE_TEST Jean Delvare
2023-12-13 15:38 ` Lee Jones [this message]
2023-12-13 19:55 ` Jean Delvare
2023-12-21 14:36 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231213153838.GM111411@google.com \
--to=lee@kernel.org \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox