From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B21AFC4332F for ; Wed, 13 Dec 2023 16:19:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377687AbjLMQTD (ORCPT ); Wed, 13 Dec 2023 11:19:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229975AbjLMQSz (ORCPT ); Wed, 13 Dec 2023 11:18:55 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C46619F for ; Wed, 13 Dec 2023 08:18:58 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65902C433C7; Wed, 13 Dec 2023 16:18:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702484338; bh=KKtcCxUBiYEf/ALdZbGfMASRpIGnU7Bu8dtqIeEgDsI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oo6LBVHrptCd7MKbR7lQ0IdPWsvdjqwSdmXOFwlaku+/UoTXVmsUn7oHh2to6ftjG N7efZNWJw5aD3jrdZpKXE3mUyrHXd57nfH54UAIJonJ9SVbjgXSSiPNu4DHrOMgK2u WiTiUKSDruB3sK9YGa3LhzKnlwijGWiRdryfGv1UCcMKVrJZ2N19xvbnMVmH/8H+0I O24Ku/aZo0XJsV1s4DvcR6FIm97l0sPWHqTva3x51w4m+Z7lmzvGRI6YPeUe53SrGs RPhLbQOAQ7T2Z3z0ST0opSLTrE+CUGN+/OyEXXsK0tEA/mJDWJxWSLfAXsCRfE0xCf FP0eGmt3ewgtw== Date: Wed, 13 Dec 2023 16:18:54 +0000 From: Lee Jones To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, Alex Vinarskis Subject: Re: [PATCH v1 1/1] mfd: intel-lpss: Fix the fractional clock divider flags Message-ID: <20231213161854.GR111411@google.com> References: <20231211111441.3910083-1-andriy.shevchenko@linux.intel.com> <20231213161352.GQ111411@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 Dec 2023, Andy Shevchenko wrote: > On Wed, Dec 13, 2023 at 04:13:52PM +0000, Lee Jones wrote: > > On Mon, 11 Dec 2023, Andy Shevchenko wrote: > > ... > > > > tmp = clk_register_fractional_divider(NULL, name, __clk_get_name(tmp), > > > + 0, lpss->priv, 1, 15, 16, 15, > > > CLK_FRAC_DIVIDER_POWER_OF_TWO_PS, > > > - lpss->priv, 1, 15, 16, 15, 0, > > > NULL); > > > > What an ugly interface. Intel-only too, right? > > Nope, de facto way how custom clocks are being introduced. > See clk-provider.h for several similar APIs (that require an > additional, custom, flags to be supplied). This call only has 2 call-sites, both Intel. Anyway, just checking to ensure both are being fixed-up. -- Lee Jones [李琼斯]