From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAA26C4332F for ; Wed, 13 Dec 2023 17:46:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233416AbjLMRqF (ORCPT ); Wed, 13 Dec 2023 12:46:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233207AbjLMRqD (ORCPT ); Wed, 13 Dec 2023 12:46:03 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0950399 for ; Wed, 13 Dec 2023 09:46:10 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF299C433C7; Wed, 13 Dec 2023 17:46:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702489569; bh=X3fZW1ftoAwjxfIDgegK09VezD4UiqgtwXe9IKxubq4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R/3dmiHc6DO0k/nqHigU6D0v9tb8kZ+4qgetXpz4BvSpBhA7GBt2O7mXiX0qyq74c m/0cuyYUWwZsnQYwuLxrOIu/brlRi6cP8J0JZUrQD1KhmLj9SkpbCHRpXpWhmr6erD oo4rDkawuACkX/zkGNc5b2ylziR6R7PAn/NOkvBy57KQogt22Tf/VKr8x39YyYlu2d tG4hOvczRzzYG3QgtgZtOKKYanwpSdiTeWttrm9bBLN8M/DuZjXk1QrW+wnkBjkvaa V3JcAUnH17+QbFFuV6Su0+5XRMuCVNTlTYG3ZLYLPk+BpmjKn2FvrmJnOEeSLS1uwM bxc/WMEcDU45Q== Date: Wed, 13 Dec 2023 17:46:05 +0000 From: Lee Jones To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org, Alex Vinarskis Subject: Re: [PATCH v1 1/1] mfd: intel-lpss: Fix the fractional clock divider flags Message-ID: <20231213174605.GS111411@google.com> References: <20231211111441.3910083-1-andriy.shevchenko@linux.intel.com> <20231213161352.GQ111411@google.com> <20231213161854.GR111411@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 Dec 2023, Andy Shevchenko wrote: > On Wed, Dec 13, 2023 at 04:18:54PM +0000, Lee Jones wrote: > > On Wed, 13 Dec 2023, Andy Shevchenko wrote: > > > On Wed, Dec 13, 2023 at 04:13:52PM +0000, Lee Jones wrote: > > > > On Mon, 11 Dec 2023, Andy Shevchenko wrote: > > ... > > > > > > tmp = clk_register_fractional_divider(NULL, name, __clk_get_name(tmp), > > > > > + 0, lpss->priv, 1, 15, 16, 15, > > > > > CLK_FRAC_DIVIDER_POWER_OF_TWO_PS, > > > > > - lpss->priv, 1, 15, 16, 15, 0, > > > > > NULL); > > > > > > > > What an ugly interface. Intel-only too, right? > > > > > > Nope, de facto way how custom clocks are being introduced. > > > See clk-provider.h for several similar APIs (that require an > > > additional, custom, flags to be supplied). > > > > This call only has 2 call-sites, both Intel. > > Yes, but the clock fractional divider is used wider. > > And again, it's not related to Intel, as this how clock framework > does the custom clocks. I don't know how to say this clearer. I'm not sure how you can say that. Intel were the authors, hold the _only_ copyright and are the _only_ users. If it were to be removed, there is only a single entity that would even notice. Anyway, it was just a passing comment. Not positive, not negative. -- Lee Jones [李琼斯]