From: Conor Dooley <conor@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] dt-bindings: net: marvell,orion-mdio: Drop "reg" sizes schema
Date: Thu, 14 Dec 2023 16:23:48 +0000 [thread overview]
Message-ID: <20231214-buzz-playlist-2f75095ef2b0@spud> (raw)
In-Reply-To: <20231213232455.2248056-1-robh@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1602 bytes --]
On Wed, Dec 13, 2023 at 05:24:55PM -0600, Rob Herring wrote:
> Defining the size of register regions is not really in scope of what
> bindings need to cover. The schema for this is also not completely correct
> as a reg entry can be variable number of cells for the address and size,
> but the schema assumes 1 cell.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Does this not also remove restrictions on what the number in the reg
entry is actually allowed to be?
> ---
> .../bindings/net/marvell,orion-mdio.yaml | 22 -------------------
> 1 file changed, 22 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml b/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml
> index e35da8b01dc2..73429855d584 100644
> --- a/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml
> +++ b/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml
> @@ -39,28 +39,6 @@ required:
> allOf:
> - $ref: mdio.yaml#
>
> - - if:
> - required:
> - - interrupts
> -
> - then:
> - properties:
> - reg:
> - items:
> - - items:
> - - $ref: /schemas/types.yaml#/definitions/cell
> - - const: 0x84
> -
> - else:
> - properties:
> - reg:
> - items:
> - - items:
> - - $ref: /schemas/types.yaml#/definitions/cell
> - - enum:
> - - 0x4
> - - 0x10
> -
> unevaluatedProperties: false
>
> examples:
> --
> 2.43.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-12-14 16:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 23:24 [PATCH net-next] dt-bindings: net: marvell,orion-mdio: Drop "reg" sizes schema Rob Herring
2023-12-14 16:23 ` Conor Dooley [this message]
2023-12-14 18:12 ` Rob Herring
2023-12-15 10:18 ` Andrew Lunn
2023-12-15 15:41 ` Rob Herring
2023-12-15 15:57 ` Andrew Lunn
2023-12-15 15:53 ` Andrew Lunn
2023-12-16 2:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231214-buzz-playlist-2f75095ef2b0@spud \
--to=conor@kernel.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox