public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: tanzirh@google.com
To: Kees Cook <keescook@chromium.org>
Cc: Andy Shevchenko <andy@kernel.org>,
	linux-hardening@vger.kernel.org,  linux-kernel@vger.kernel.org,
	Nick DeSaulniers <nnn@google.com>,
	 Andrew Morton <akpm@linux-foundation.org>,
	llvm@lists.linux.dev,  Tanzir Hasan <tanzirh@google.com>
Subject: [PATCH v2 2/2] lib/string: shrink lib/string.i via IWYU
Date: Thu, 14 Dec 2023 21:06:13 +0000	[thread overview]
Message-ID: <20231214-libstringheader-v2-2-0f195dcff204@google.com> (raw)
In-Reply-To: <20231214-libstringheader-v2-0-0f195dcff204@google.com>

This diff uses an open source tool include-what-you-use (IWYU) to modify
the include list changing indirect includes to direct includes.
IWYU is implemented using the IWYUScripts github repository which is a tool that is
currently undergoing development. These changes seek to improve build times.

This change to lib/string.c resulted in a preprocessed size of
lib/string.i from 26371 lines to 5259 lines (-80%) for the x86
defconfig.

Link: https://github.com/ClangBuiltLinux/IWYUScripts

Signed-off-by: Tanzir Hasan <tanzirh@google.com>
---
 lib/string.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/lib/string.c b/lib/string.c
index be26623953d2..7fe1acefb1a1 100644
--- a/lib/string.c
+++ b/lib/string.c
@@ -16,16 +16,16 @@
 
 #define __NO_FORTIFY
 #include <linux/types.h>
-#include <linux/string.h>
-#include <linux/ctype.h>
-#include <linux/kernel.h>
-#include <linux/export.h>
+#include <linux/bits.h>
 #include <linux/bug.h>
 #include <linux/errno.h>
-#include <linux/slab.h>
-
+#include <asm/rwonce.h>
+#include <linux/linkage.h>
+#include <linux/stddef.h>
+#include <vdso/limits.h>
+#include <linux/string.h>
+#include <linux/ctype.h>
 #include <asm/unaligned.h>
-#include <asm/byteorder.h>
 #include <asm/word-at-a-time.h>
 #include <asm/page.h>
 

-- 
2.43.0.472.g3155946c3a-goog


  parent reply	other threads:[~2023-12-14 21:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-14 21:06 [PATCH v2 0/2] shrink lib/string.i via IWYU tanzirh
2023-12-14 21:06 ` [PATCH v2 1/2] sh: Added kernel.h to word-at-a-time tanzirh
2023-12-14 21:37   ` Kees Cook
2023-12-14 21:51     ` Nick Desaulniers
2023-12-15 16:04   ` Andy Shevchenko
     [not found]     ` <CAE-cH4p5VJ_A91BAkURBN67ACA0_u7T8UhApUYLQDWeeRY6FWA@mail.gmail.com>
2023-12-15 19:09       ` Andy Shevchenko
2023-12-18 16:57         ` Nick Desaulniers
2023-12-18 17:05           ` Tanzir Hasan
2023-12-18 17:25             ` Andy Shevchenko
2023-12-18 17:23           ` Andy Shevchenko
2023-12-14 21:06 ` tanzirh [this message]
2023-12-14 21:39   ` [PATCH v2 2/2] lib/string: shrink lib/string.i via IWYU Kees Cook
2023-12-15 16:08   ` Andy Shevchenko
2024-01-09 21:49   ` Justin Stitt
2024-01-11  0:07     ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231214-libstringheader-v2-2-0f195dcff204@google.com \
    --to=tanzirh@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=andy@kernel.org \
    --cc=keescook@chromium.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=nnn@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox