Re: [PATCH v13 11/21] PCI: microchip: Add num_events field to struct plda_pcie_rp

Minda Chen
2023-12-29T03:46:18Z

On 2023/12/27 23:55, Lorenzo Pieralisi wrote:
> On Thu, Dec 14, 2023 at 03:28:29PM +0800, Minda Chen wrote:
>> The event num is different in other platform. For re-using interrupt
>> process codes, replace macros with variable.
>
> "The number of events is different across platforms. In order to
> share interrupt processing code, add a variable that defines the
> number of events so that it can be set per-platform instead of
> hardcoding it".
>
> Lorenzo
>
Thanks for reviewing. Happy new year!

All the maintainers:
Happy new year!

>>
>> Signed-off-by: Minda Chen <minda.chen@starfivetech.com>
>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>> ---
>> drivers/pci/controller/plda/pcie-microchip-host.c | 8 +++++---
>> drivers/pci/controller/plda/pcie-plda.h | 1 +
>> 2 files changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/pci/controller/plda/pcie-microchip-host.c b/drivers/pci/controller/plda/pcie-microchip-host.c
>> index 506e6eeadc76..7b3f4f74745d 100644
>> --- a/drivers/pci/controller/plda/pcie-microchip-host.c
>> +++ b/drivers/pci/controller/plda/pcie-microchip-host.c
>> @@ -654,7 +654,7 @@ static void plda_handle_event(struct irq_desc *desc)
>>
>> events = mc_get_events(port);
>>
>> - for_each_set_bit(bit, &events, NUM_EVENTS)
>> + for_each_set_bit(bit, &events, port->num_events)
>> generic_handle_domain_irq(port->event_domain, bit);
>>
>> chained_irq_exit(chip, desc);
>> @@ -817,7 +817,8 @@ static int plda_pcie_init_irq_domains(struct plda_pcie_rp *port)
>> return -EINVAL;
>> }
>>
>> - port->event_domain = irq_domain_add_linear(pcie_intc_node, NUM_EVENTS,
>> + port->event_domain = irq_domain_add_linear(pcie_intc_node,
>> + port->num_events,
>> &plda_event_domain_ops,
>> port);
>> if (!port->event_domain) {
>> @@ -921,7 +922,7 @@ static int plda_init_interrupts(struct platform_device *pdev, struct plda_pcie_r
>> if (irq < 0)
>> return -ENODEV;
>>
>> - for (i = 0; i < NUM_EVENTS; i++) {
>> + for (i = 0; i < port->num_events; i++) {
>> event_irq = irq_create_mapping(port->event_domain, i);
>> if (!event_irq) {
>> dev_err(dev, "failed to map hwirq %d\n", i);
>> @@ -1013,6 +1014,7 @@ static int mc_host_probe(struct platform_device *pdev)
>>
>> bridge_base_addr = port->axi_base_addr + MC_PCIE_BRIDGE_ADDR;
>> plda->bridge_addr = bridge_base_addr;
>> + plda->num_events = NUM_EVENTS;
>>
>> /* Allow enabling MSI by disabling MSI-X */
>> val = readl(bridge_base_addr + PCIE_PCI_IRQ_DW0);
>> diff --git a/drivers/pci/controller/plda/pcie-plda.h b/drivers/pci/controller/plda/pcie-plda.h
>> index 3deefd35fa5a..e3d35cef9894 100644
>> --- a/drivers/pci/controller/plda/pcie-plda.h
>> +++ b/drivers/pci/controller/plda/pcie-plda.h
>> @@ -118,6 +118,7 @@ struct plda_pcie_rp {
>> raw_spinlock_t lock;
>> struct plda_msi msi;
>> void __iomem *bridge_addr;
>> + int num_events;
>> };
>>
>> void plda_pcie_setup_window(void __iomem *bridge_base_addr, u32 index,
>> --
>> 2.17.1
>>