Re: [PATCH 6/9] PCI: epf-mhi: Enable MHI async read/write support

Krzysztof Wilczyński
2023-12-13T18:48:36Z

Hello,

Manivannan, you will be taking this through the MHI tree, correct?

> Now that both eDMA and iATU are prepared to support async transfer, let's
> enable MHI async read/write by supplying the relevant callbacks.
>
> In the absence of eDMA, iATU will be used for both sync and async
> operations.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> drivers/pci/endpoint/functions/pci-epf-mhi.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/endpoint/functions/pci-epf-mhi.c b/drivers/pci/endpoint/functions/pci-epf-mhi.c
> index 3d09a37e5f7c..d3d6a1054036 100644
> --- a/drivers/pci/endpoint/functions/pci-epf-mhi.c
> +++ b/drivers/pci/endpoint/functions/pci-epf-mhi.c
> @@ -766,12 +766,13 @@ static int pci_epf_mhi_link_up(struct pci_epf *epf)
> mhi_cntrl->raise_irq = pci_epf_mhi_raise_irq;
> mhi_cntrl->alloc_map = pci_epf_mhi_alloc_map;
> mhi_cntrl->unmap_free = pci_epf_mhi_unmap_free;
> + mhi_cntrl->read_sync = mhi_cntrl->read_async = pci_epf_mhi_iatu_read;
> + mhi_cntrl->write_sync = mhi_cntrl->write_async = pci_epf_mhi_iatu_write;
> if (info->flags & MHI_EPF_USE_DMA) {
> mhi_cntrl->read_sync = pci_epf_mhi_edma_read;
> mhi_cntrl->write_sync = pci_epf_mhi_edma_write;
> - } else {
> - mhi_cntrl->read_sync = pci_epf_mhi_iatu_read;
> - mhi_cntrl->write_sync = pci_epf_mhi_iatu_write;
> + mhi_cntrl->read_async = pci_epf_mhi_edma_read_async;
> + mhi_cntrl->write_async = pci_epf_mhi_edma_write_async;
> }

Looks good!

Reviewed-by: Krzysztof Wilczyński <kw@linux.com>

Krzysztof