From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F32956ABBF for ; Thu, 14 Dec 2023 21:37:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="jgikFXiU" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1d0c4d84bf6so52838195ad.1 for ; Thu, 14 Dec 2023 13:37:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1702589866; x=1703194666; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CoBcF2VO2o0vu9XC2M9RSfeyOc73hCRdoFweAl1iysg=; b=jgikFXiUQ/vLBJOTiLU0UAYH+cD0H+twmoJMlrEIZ2NHcslHJvZW1yVIHXIv3iEplC hxdzKtVDAOR7VX6n6M+GuHXTCiLzDYnaB2uV9qFm1yyqG4DZFNxJGDbKHrnFIvVCmglT rrKrxlC/2LAf1l5cjS9Udq0pmp6AZ11bIErC0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702589866; x=1703194666; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CoBcF2VO2o0vu9XC2M9RSfeyOc73hCRdoFweAl1iysg=; b=xSBkWhaZ9hQTLhYWGQ+tO92jYOoEEuCu1EmT/MrOeGtDVi480kBNpJnCS0LB+OJp+o F0Hoc0jAYgSSKVCnaXW3n1gdq3vLW6OxbgIXr6gICaykSt9NpvqmWTv5IsC37tzmkOIR 4tetqjHsAuvAaakEaWP6jgbc4kqv7B8UumkuvZt0rfII5CyjTlnHtC89nXK+Ll20fUUh V+fOtwoMMzt2u9OxkhP9VQovIoXh3wiGTXUxXy0XaE5kJMUmRY1wb3Fn4KTOoDRrHGq9 grzQwUlVtjHxTDbyeAsmZu6LRDaly20F7L40dbQ1rAfTmSW3yEIW6xjrXtRxOGaVI50N CNDw== X-Gm-Message-State: AOJu0Yynk7OZwRMqjAusAGXtf3M2jTNgLz+ZmvOPayEmQ7FnubzYVFLo 2yZgg1sswukvyirihHt6ZfNTxQ== X-Google-Smtp-Source: AGHT+IGiNnCSqfi9NhA3YuSaQM+1pX8bYPHHVgcte0hFIjkH7thLyLUNZ6FFoPuMhywABFfzjEa/dg== X-Received: by 2002:a17:902:e804:b0:1cf:7c3d:df68 with SMTP id u4-20020a170902e80400b001cf7c3ddf68mr7534686plg.39.1702589866015; Thu, 14 Dec 2023 13:37:46 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id iw21-20020a170903045500b001d3650256fdsm2016861plb.294.2023.12.14.13.37.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 13:37:45 -0800 (PST) Date: Thu, 14 Dec 2023 13:37:44 -0800 From: Kees Cook To: tanzirh@google.com Cc: Andy Shevchenko , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, Nick DeSaulniers , Andrew Morton , llvm@lists.linux.dev, Al Viro Subject: Re: [PATCH v2 1/2] sh: Added kernel.h to word-at-a-time Message-ID: <202312141335.45C785B0@keescook> References: <20231214-libstringheader-v2-0-0f195dcff204@google.com> <20231214-libstringheader-v2-1-0f195dcff204@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231214-libstringheader-v2-1-0f195dcff204@google.com> On Thu, Dec 14, 2023 at 09:06:12PM +0000, tanzirh@google.com wrote: > This patch includes linux/kernel.h in asm/word-at-a-time.h for the > sh architecture. WORD_AT_A_TIME_CONSTANTS depends on kernel.h. > Making this implicit dependancy explicit allows for later improvements > in the lib/string.c inclusion list. > > Suggested-by: Al Viro This patch is missing your Signed-off-by: tag. Also, please double-check your email configs: your full name is missing from your emails (it's just "tanzirh@google.com"): https://lore.kernel.org/lkml/20231214-libstringheader-v2-1-0f195dcff204@google.com/ But otherwise, the change itself looks fine. :) -- Kees Cook