From: "Krzysztof Wilczyński" <kw@linux.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: Rob Herring <robh@kernel.org>,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pci: rcar-gen4: Replace of_device.h with explicit of.h include
Date: Fri, 15 Dec 2023 04:22:34 +0900 [thread overview]
Message-ID: <20231214192234.GC2079458@rocinante> (raw)
In-Reply-To: <TYBPR01MB53415F2C51CB51A0ADFBD278D88CA@TYBPR01MB5341.jpnprd01.prod.outlook.com>
Hello,
> > > The DT of_device.h and of_platform.h date back to the separate
> > > of_platform_bus_type before it was merged into the regular platform bus.
> > > As part of that merge prepping Arm DT support 13 years ago, they
> > > "temporarily" include each other. They also include platform_device.h
> > > and of.h. As a result, there's a pretty much random mix of those include
> > > files used throughout the tree. In order to detangle these headers and
> > > replace the implicit includes with struct declarations, users need to
> > > explicitly include the correct includes.
> >
> > Applied to controller/rcar, thank you!
> >
> > [1/1] PCI: rcar-gen4: Replace of_device.h with explicit of.h include
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?id=263714f5fcf8
>
> Thank you! I completely overlooked this patch. Maybe it's too late, but I also reviewed this patch, so
>
> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>
> It's up to you whether my tag is added to the commit or not :)
No worries. Never too late for a good review. :)
As such, I added your Reviewed-by, so it should be there, per:
https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/rcar&id=ec215237480478ca5523ea12f58803d9b7a8a0ea
Krzysztof
prev parent reply other threads:[~2023-12-14 19:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 16:52 [PATCH] pci: rcar-gen4: Replace of_device.h with explicit of.h include Rob Herring
2023-12-14 1:33 ` Krzysztof Wilczyński
2023-12-14 2:28 ` Yoshihiro Shimoda
2023-12-14 19:22 ` Krzysztof Wilczyński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231214192234.GC2079458@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=robh@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox