From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A076C4167B for ; Thu, 14 Dec 2023 14:41:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573533AbjLNOlf (ORCPT ); Thu, 14 Dec 2023 09:41:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230298AbjLNOld (ORCPT ); Thu, 14 Dec 2023 09:41:33 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A937F125 for ; Thu, 14 Dec 2023 06:41:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702564900; x=1734100900; h=date:from:to:cc:subject:message-id:mime-version; bh=fO4V+ejCyUnzWk/Rt58KkdhI5/UtBknV5DJ/XG96U9Y=; b=cKvCbDEW8Bk3Gih4ul7m72taq/M/nKTQMRXIvPVqtI3YgK2nire99ukf mPp1VNBBZZ5WP6jZyrn2ucah9Wwpj+XIAYv7JVmVk8R3qr3uf+a8x/9+J D7t6LByMX3YS+xFqiQVcrWJ6FcIswJfVkhM7VuN5+w+pz1GwDgr6sn9/H fvsI0tYnECCUo9yT3eH3S4YXSh0l3U9MUr5htmYtLo6W2ONX1VChaLtIc +FUTAbE3PWQe9DtRF5vCOAD7G3xual8rsFsn6hptwPsQG1QjA94IQtW8F 7u0R0k9SEXmUbni+waIrUYyard9fRBIi4oqj0oelbqX/0wovRLqMWH5iN w==; X-IronPort-AV: E=McAfee;i="6600,9927,10924"; a="16675699" X-IronPort-AV: E=Sophos;i="6.04,275,1695711600"; d="scan'208";a="16675699" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2023 06:41:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,275,1695711600"; d="scan'208";a="22432856" Received: from lkp-server02.sh.intel.com (HELO b07ab15da5fe) ([10.239.97.151]) by orviesa001.jf.intel.com with ESMTP; 14 Dec 2023 06:41:35 -0800 Received: from kbuild by b07ab15da5fe with local (Exim 4.96) (envelope-from ) id 1rDmu3-000MBQ-2l; Thu, 14 Dec 2023 14:41:31 +0000 Date: Thu, 14 Dec 2023 22:40:40 +0800 From: kernel test robot To: Thomas Gleixner Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Ingo Molnar Subject: arch/x86/kernel/apic/apic.c:2135: warning: Function parameter or member 'spurious_interrupt' not described in 'DEFINE_IDTENTRY_IRQ' Message-ID: <202312142220.6hKrNeSe-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thomas, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5bd7ef53ffe5ca580e93e74eb8c81ed191ddc4bd commit: fa5e5c409213265da8a188b4a5e4e641b1382eb4 x86/entry: Use idtentry for interrupts date: 3 years, 6 months ago config: x86_64-allnoconfig (https://download.01.org/0day-ci/archive/20231214/202312142220.6hKrNeSe-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231214/202312142220.6hKrNeSe-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202312142220.6hKrNeSe-lkp@intel.com/ All warnings (new ones prefixed by >>): >> arch/x86/kernel/apic/apic.c:2135: warning: Function parameter or member 'spurious_interrupt' not described in 'DEFINE_IDTENTRY_IRQ' >> arch/x86/kernel/apic/apic.c:2135: warning: expecting prototype for spurious_interrupt(). Prototype was for DEFINE_IDTENTRY_IRQ() instead vim +2135 arch/x86/kernel/apic/apic.c c0104d38a740b2 arch/x86/kernel/apic/apic.c Yinghai Lu 2010-12-07 2118 ^1da177e4c3f41 arch/x86_64/kernel/apic.c Linus Torvalds 2005-04-16 2119 /* 0e078e2f5060e0 arch/x86/kernel/apic_64.c Thomas Gleixner 2008-01-30 2120 * Local APIC interrupts ^1da177e4c3f41 arch/x86_64/kernel/apic.c Linus Torvalds 2005-04-16 2121 */ ^1da177e4c3f41 arch/x86_64/kernel/apic.c Linus Torvalds 2005-04-16 2122 633260fa143bbe arch/x86/kernel/apic/apic.c Thomas Gleixner 2020-05-21 2123 /** fa5e5c40921326 arch/x86/kernel/apic/apic.c Thomas Gleixner 2020-05-21 2124 * spurious_interrupt - Catch all for interrupts raised on unused vectors 633260fa143bbe arch/x86/kernel/apic/apic.c Thomas Gleixner 2020-05-21 2125 * @regs: Pointer to pt_regs on stack fa5e5c40921326 arch/x86/kernel/apic/apic.c Thomas Gleixner 2020-05-21 2126 * @vector: The vector number 633260fa143bbe arch/x86/kernel/apic/apic.c Thomas Gleixner 2020-05-21 2127 * 633260fa143bbe arch/x86/kernel/apic/apic.c Thomas Gleixner 2020-05-21 2128 * This is invoked from ASM entry code to catch all interrupts which 633260fa143bbe arch/x86/kernel/apic/apic.c Thomas Gleixner 2020-05-21 2129 * trigger on an entry which is routed to the common_spurious idtentry 633260fa143bbe arch/x86/kernel/apic/apic.c Thomas Gleixner 2020-05-21 2130 * point. 633260fa143bbe arch/x86/kernel/apic/apic.c Thomas Gleixner 2020-05-21 2131 * 633260fa143bbe arch/x86/kernel/apic/apic.c Thomas Gleixner 2020-05-21 2132 * Also called from smp_spurious_apic_interrupt(). 0e078e2f5060e0 arch/x86/kernel/apic_64.c Thomas Gleixner 2008-01-30 2133 */ fa5e5c40921326 arch/x86/kernel/apic/apic.c Thomas Gleixner 2020-05-21 2134 DEFINE_IDTENTRY_IRQ(spurious_interrupt) ^1da177e4c3f41 arch/x86_64/kernel/apic.c Linus Torvalds 2005-04-16 @2135 { dc1528dd864a0b arch/x86/kernel/apic_64.c Yinghai Lu 2008-08-24 2136 u32 v; dc1528dd864a0b arch/x86/kernel/apic_64.c Yinghai Lu 2008-08-24 2137 61069de7a3252b arch/x86/kernel/apic/apic.c Thomas Gleixner 2017-08-28 2138 trace_spurious_apic_entry(vector); 61069de7a3252b arch/x86/kernel/apic/apic.c Thomas Gleixner 2017-08-28 2139 f8a8fe61fec800 arch/x86/kernel/apic/apic.c Thomas Gleixner 2019-06-28 2140 inc_irq_stat(irq_spurious_count); f8a8fe61fec800 arch/x86/kernel/apic/apic.c Thomas Gleixner 2019-06-28 2141 f8a8fe61fec800 arch/x86/kernel/apic/apic.c Thomas Gleixner 2019-06-28 2142 /* f8a8fe61fec800 arch/x86/kernel/apic/apic.c Thomas Gleixner 2019-06-28 2143 * If this is a spurious interrupt then do not acknowledge f8a8fe61fec800 arch/x86/kernel/apic/apic.c Thomas Gleixner 2019-06-28 2144 */ f8a8fe61fec800 arch/x86/kernel/apic/apic.c Thomas Gleixner 2019-06-28 2145 if (vector == SPURIOUS_APIC_VECTOR) { f8a8fe61fec800 arch/x86/kernel/apic/apic.c Thomas Gleixner 2019-06-28 2146 /* See SDM vol 3 */ f8a8fe61fec800 arch/x86/kernel/apic/apic.c Thomas Gleixner 2019-06-28 2147 pr_info("Spurious APIC interrupt (vector 0xFF) on CPU#%d, should never happen.\n", f8a8fe61fec800 arch/x86/kernel/apic/apic.c Thomas Gleixner 2019-06-28 2148 smp_processor_id()); f8a8fe61fec800 arch/x86/kernel/apic/apic.c Thomas Gleixner 2019-06-28 2149 goto out; f8a8fe61fec800 arch/x86/kernel/apic/apic.c Thomas Gleixner 2019-06-28 2150 } f8a8fe61fec800 arch/x86/kernel/apic/apic.c Thomas Gleixner 2019-06-28 2151 0e078e2f5060e0 arch/x86/kernel/apic_64.c Thomas Gleixner 2008-01-30 2152 /* f8a8fe61fec800 arch/x86/kernel/apic/apic.c Thomas Gleixner 2019-06-28 2153 * If it is a vectored one, verify it's set in the ISR. If set, f8a8fe61fec800 arch/x86/kernel/apic/apic.c Thomas Gleixner 2019-06-28 2154 * acknowledge it. 0e078e2f5060e0 arch/x86/kernel/apic_64.c Thomas Gleixner 2008-01-30 2155 */ 2414e021ac8d58 arch/x86/kernel/apic/apic.c Jan Beulich 2014-11-03 2156 v = apic_read(APIC_ISR + ((vector & ~0x1f) >> 1)); f8a8fe61fec800 arch/x86/kernel/apic/apic.c Thomas Gleixner 2019-06-28 2157 if (v & (1 << (vector & 0x1f))) { fa5e5c40921326 arch/x86/kernel/apic/apic.c Thomas Gleixner 2020-05-21 2158 pr_info("Spurious interrupt (vector 0x%02x) on CPU#%d. Acked\n", f8a8fe61fec800 arch/x86/kernel/apic/apic.c Thomas Gleixner 2019-06-28 2159 vector, smp_processor_id()); 0e078e2f5060e0 arch/x86/kernel/apic_64.c Thomas Gleixner 2008-01-30 2160 ack_APIC_irq(); f8a8fe61fec800 arch/x86/kernel/apic/apic.c Thomas Gleixner 2019-06-28 2161 } else { fa5e5c40921326 arch/x86/kernel/apic/apic.c Thomas Gleixner 2020-05-21 2162 pr_info("Spurious interrupt (vector 0x%02x) on CPU#%d. Not pending!\n", f8a8fe61fec800 arch/x86/kernel/apic/apic.c Thomas Gleixner 2019-06-28 2163 vector, smp_processor_id()); f8a8fe61fec800 arch/x86/kernel/apic/apic.c Thomas Gleixner 2019-06-28 2164 } f8a8fe61fec800 arch/x86/kernel/apic/apic.c Thomas Gleixner 2019-06-28 2165 out: 2414e021ac8d58 arch/x86/kernel/apic/apic.c Jan Beulich 2014-11-03 2166 trace_spurious_apic_exit(vector); 0e078e2f5060e0 arch/x86/kernel/apic_64.c Thomas Gleixner 2008-01-30 2167 } c4d58cbd158dc9 arch/x86/kernel/apic_64.c Thomas Gleixner 2007-10-12 2168 :::::: The code at line 2135 was first introduced by commit :::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2 :::::: TO: Linus Torvalds :::::: CC: Linus Torvalds -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki