From: Benjamin Gaignard <benjamin.gaignard@collabora.com>
To: hverkuil@xs4all.nl, mchehab@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
kernel@collabora.com,
Benjamin Gaignard <benjamin.gaignard@collabora.com>
Subject: [PATCH v16 2/8] media: test-drivers: Set REQBUFS minimum number of buffers
Date: Fri, 15 Dec 2023 10:08:07 +0100 [thread overview]
Message-ID: <20231215090813.15610-3-benjamin.gaignard@collabora.com> (raw)
In-Reply-To: <20231215090813.15610-1-benjamin.gaignard@collabora.com>
Test drivers require at least 2 buffers to be allocated when
calling REQBUFS so set queue min_reqbufs_allocation field instead
of min_queued_buffers.
While at it remane vivid_create_queue() parameter.
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
---
drivers/media/test-drivers/vimc/vimc-capture.c | 2 +-
drivers/media/test-drivers/vivid/vivid-core.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/test-drivers/vimc/vimc-capture.c b/drivers/media/test-drivers/vimc/vimc-capture.c
index 2a2d19d23bab..97693561f1e4 100644
--- a/drivers/media/test-drivers/vimc/vimc-capture.c
+++ b/drivers/media/test-drivers/vimc/vimc-capture.c
@@ -432,7 +432,7 @@ static struct vimc_ent_device *vimc_capture_add(struct vimc_device *vimc,
q->mem_ops = vimc_allocator == VIMC_ALLOCATOR_DMA_CONTIG
? &vb2_dma_contig_memops : &vb2_vmalloc_memops;
q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
- q->min_queued_buffers = 2;
+ q->min_reqbufs_allocation = 2;
q->lock = &vcapture->lock;
q->dev = v4l2_dev->dev;
diff --git a/drivers/media/test-drivers/vivid/vivid-core.c b/drivers/media/test-drivers/vivid/vivid-core.c
index 159c72cbb5bf..11b8520d9f57 100644
--- a/drivers/media/test-drivers/vivid/vivid-core.c
+++ b/drivers/media/test-drivers/vivid/vivid-core.c
@@ -861,7 +861,7 @@ static const struct media_device_ops vivid_media_ops = {
static int vivid_create_queue(struct vivid_dev *dev,
struct vb2_queue *q,
u32 buf_type,
- unsigned int min_queued_buffers,
+ unsigned int min_reqbufs_allocation,
const struct vb2_ops *ops)
{
if (buf_type == V4L2_BUF_TYPE_VIDEO_CAPTURE && dev->multiplanar)
@@ -898,7 +898,7 @@ static int vivid_create_queue(struct vivid_dev *dev,
q->mem_ops = allocators[dev->inst] == 1 ? &vb2_dma_contig_memops :
&vb2_vmalloc_memops;
q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
- q->min_queued_buffers = supports_requests[dev->inst] ? 0 : min_queued_buffers;
+ q->min_reqbufs_allocation = min_reqbufs_allocation;
q->lock = &dev->mutex;
q->dev = dev->v4l2_dev.dev;
q->supports_requests = supports_requests[dev->inst];
--
2.40.1
next prev parent reply other threads:[~2023-12-15 9:08 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 9:08 [PATCH v16 0/8] Add DELETE_BUF ioctl Benjamin Gaignard
2023-12-15 9:08 ` [PATCH v16 1/8] videobuf2: Add min_reqbufs_allocation field to vb2_queue structure Benjamin Gaignard
2024-01-15 9:16 ` Hans Verkuil
2024-01-15 10:27 ` Hans Verkuil
2023-12-15 9:08 ` Benjamin Gaignard [this message]
2024-01-15 10:35 ` [PATCH v16 2/8] media: test-drivers: Set REQBUFS minimum number of buffers Hans Verkuil
2023-12-15 9:08 ` [PATCH v16 3/8] media: core: Rework how create_buf index returned value is computed Benjamin Gaignard
2024-01-15 11:00 ` Hans Verkuil
2024-01-15 11:40 ` Hans Verkuil
2024-01-15 12:11 ` Hans Verkuil
2024-01-15 14:52 ` Benjamin Gaignard
2024-01-15 15:17 ` Hans Verkuil
2024-01-15 16:04 ` Hans Verkuil
2023-12-15 9:08 ` [PATCH v16 4/8] media: core: Add bitmap manage bufs array entries Benjamin Gaignard
2024-01-15 12:21 ` Hans Verkuil
2024-01-15 14:51 ` Benjamin Gaignard
2024-01-15 15:14 ` Hans Verkuil
2023-12-15 9:08 ` [PATCH v16 5/8] media: core: Free range of buffers Benjamin Gaignard
2024-01-15 16:08 ` Hans Verkuil
2023-12-15 9:08 ` [PATCH v16 6/8] media: v4l2: Add DELETE_BUFS ioctl Benjamin Gaignard
2024-01-15 16:43 ` Hans Verkuil
2024-01-16 9:37 ` Benjamin Gaignard
2023-12-15 9:08 ` [PATCH v16 7/8] media: v4l2: Add mem2mem helpers for " Benjamin Gaignard
2024-01-15 16:50 ` Hans Verkuil
2024-01-16 10:42 ` Benjamin Gaignard
2023-12-15 9:08 ` [PATCH v16 8/8] media: test-drivers: Use helper " Benjamin Gaignard
2024-01-15 16:53 ` Hans Verkuil
2024-01-09 9:37 ` [PATCH v16 0/8] Add DELETE_BUF ioctl Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231215090813.15610-3-benjamin.gaignard@collabora.com \
--to=benjamin.gaignard@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).