From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [91.216.245.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC88730CE1; Fri, 15 Dec 2023 14:17:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=strlen.de Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1rE904-0005oD-7W; Fri, 15 Dec 2023 15:17:12 +0100 Date: Fri, 15 Dec 2023 15:17:12 +0100 From: Florian Westphal To: "D. Wythe" Cc: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, coreteam@netfilter.org, netfilter-devel@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ast@kernel.org Subject: Re: [RFC nf-next v1 1/2] netfilter: bpf: support prog update Message-ID: <20231215141712.GA17065@breakpoint.cc> References: <1702609653-45835-1-git-send-email-alibuda@linux.alibaba.com> <1702609653-45835-2-git-send-email-alibuda@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1702609653-45835-2-git-send-email-alibuda@linux.alibaba.com> User-Agent: Mutt/1.10.1 (2018-07-13) D. Wythe wrote: > const struct nf_defrag_hook *defrag_hook; > + const struct bpf_prog __rcu *nf_prog; Hmm, why do we need this pointer? Can't you just re-use bpf_nf_link->link.prog? > + rcu_assign_pointer(nf_link->nf_prog, new_prog); > + old_prog = xchg(&link->prog, new_prog); This looks redundant, I think you can remove the nf_prog pointer again. Rest LGTM.