Re: [PATCH v8 10/24] x86/resctrl: Allocate the cleanest CLOSID by searching closid_num_dirty_rmid

Reinette Chatre
2023-12-16T05:03:36Z

Hi James,

On 12/15/2023 9:43 AM, James Morse wrote:
> MPAM's PMG bits extend its PARTID space, meaning the same PMG value can be
> used for different control groups.
>
> This means once a CLOSID is allocated, all its monitoring ids may still be
> dirty, and held in limbo.
>
> Instead of allocating the first free CLOSID, on architectures where
> CONFIG_RESCTRL_RMID_DEPENDS_ON_CLOSID is enabled, search
> closid_num_dirty_rmid[] to find the cleanest CLOSID.
>
> The CLOSID found is returned to closid_alloc() for the free list
> to be updated.
>
> Signed-off-by: James Morse <james.morse@arm.com>
> Tested-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-by: Peter Newman <peternewman@google.com>
> Tested-by: Babu Moger <babu.moger@amd.com>
> Reviewed-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
> Reviewed-by: Babu Moger <babu.moger@amd.com>
> ---
> Changes since v4:
> * Dropped stale section from comment
>
> Changes since v5:
> * Renamed some variables.
>
> Changes since v7:
> * Made comments over closid_num_dirty_rmid() not a kdoc comment.

(This is an example of me not relying on you dropping my reviewed-by tag
to take a look at new changes.)

This change is unexpected and does not have anything to do with this patch.
Instead it just seems to undo a change that sneaked into patch #8
of this series.

Reinette