Re: [PATCH v8 00/24] x86/resctrl: monitored closid+rmid together, separate arch/fs locking

James Morse
2024-01-22T18:06:57Z

Hi Carl,

On 22/12/2023 22:43, Carl Worth wrote:
> James Morse <james.morse@arm.com> writes:
>> This series does two things, it changes resctrl to call resctrl_arch_rmid_read()
>> in a way that works for MPAM, and it separates the locking so that the arch code
>> and filesystem code don't have to share a mutex. I tried to split this as two
>> series, but these touch similar call sites, so it would create more work.
>>
>> (What's MPAM? See the cover letter of the first series. [1])
>
> Thanks, James. This is really useful for us at Ampere since it enables
> the MPAM driver on top of this series.
>
> I've tested this series on an Ampere implementation, by successfully
> using resctrl to configure and exercise MPAM functionality.

Great! Thanks for this.

> I can't
> speak to the effects of the refactor on x86 since I have not tested that
> all.

> For the series:
> Tested-by: Carl Worth <carl@os.amperecomputing.com>

Thanks, I'll add an "# arm64" on the end of that to preserve your above comment about not
testing this on x86.

Thanks,

James