Re: [PATCH v8 10/24] x86/resctrl: Allocate the cleanest CLOSID by searching closid_num_dirty_rmid

James Morse
2024-01-22T18:06:16Z

Hi Reinette,

On 16/12/2023 05:01, Reinette Chatre wrote:
> On 12/15/2023 9:43 AM, James Morse wrote:
>> MPAM's PMG bits extend its PARTID space, meaning the same PMG value can be
>> used for different control groups.
>>
>> This means once a CLOSID is allocated, all its monitoring ids may still be
>> dirty, and held in limbo.
>>
>> Instead of allocating the first free CLOSID, on architectures where
>> CONFIG_RESCTRL_RMID_DEPENDS_ON_CLOSID is enabled, search
>> closid_num_dirty_rmid[] to find the cleanest CLOSID.
>>
>> The CLOSID found is returned to closid_alloc() for the free list
>> to be updated.

> (This is an example of me not relying on you dropping my reviewed-by tag
> to take a look at new changes.)

Significant changes. This is only the expected behaviour when significant changes are made
to a patch. This is a comment - and the text of the comment isn't changed.

> This change is unexpected and does not have anything to do with this patch.
> Instead it just seems to undo a change that sneaked into patch #8
> of this series.

Thanks - I was misled by closid_num_dirty_rmid existing before the patch with its name in
the subject. I'll fix this.

Thanks,

James