Re: [PATCH 2/2] usb: gadget: uvc: Remove nested locking

Greg KH
2024-01-04T14:19:29Z

On Fri, Dec 15, 2023 at 01:07:45PM -0800, Avichal Rakesh wrote:
> When handling error status from uvcg_video_usb_req_queue,
> uvc_video_complete currently calls uvcg_queue_cancel with
> video->req_lock held. uvcg_queue_cancel internally locks
> queue->irqlock, which nests queue->irqlock inside
> video->req_lock. This isn't a functional bug at the
> moment, but does open up possibilities for ABBA
> deadlocks in the future.
>
> This patch fixes the accidental nesting by dropping
> video->req_lock before calling uvcg_queue_cancel.
>
> Signed-off-by: Avichal Rakesh <arakesh@google.com>
> ---
> drivers/usb/gadget/function/uvc_video.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)

Again, what commit does this fix?

thanks,

greg k-h