The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rob Herring <robh@kernel.org>
Cc: Nipun Gupta <nipun.gupta@amd.com>,
	Nikhil Agarwal <nikhil.agarwal@amd.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] cdx: Enable COMPILE_TEST
Date: Fri, 15 Dec 2023 17:09:15 +0100	[thread overview]
Message-ID: <2023121551-uncommon-negation-fdda@gregkh> (raw)
In-Reply-To: <20231207163128.2707993-1-robh@kernel.org>

On Thu, Dec 07, 2023 at 10:31:26AM -0600, Rob Herring wrote:
> There is no reason CDX needs to depend on ARM64 other than limiting
> visibility. So let's also enable building with COMPILE_TEST.
> 
> The CONFIG_OF dependency is redundant as ARM64 always enables it and all
> the DT functions have empty stubs.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  drivers/cdx/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cdx/Kconfig b/drivers/cdx/Kconfig
> index a08958485e31..7cdb7c414453 100644
> --- a/drivers/cdx/Kconfig
> +++ b/drivers/cdx/Kconfig
> @@ -7,7 +7,7 @@
>  
>  config CDX_BUS
>  	bool "CDX Bus driver"
> -	depends on OF && ARM64
> +	depends on ARM64 || COMPILE_TEST

Ok, good start, now we need to turn this into a module, what's keeping
it from being able to be built as a tristate?

thanks,

greg k-h

  parent reply	other threads:[~2023-12-15 16:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-07 16:31 [PATCH 1/2] cdx: Enable COMPILE_TEST Rob Herring
2023-12-07 16:31 ` [PATCH 2/2] cdx: Explicitly include correct DT includes, again Rob Herring
2023-12-12  4:40   ` Agarwal, Nikhil
2023-12-12  4:40 ` [PATCH 1/2] cdx: Enable COMPILE_TEST Agarwal, Nikhil
2023-12-12 14:26   ` Rob Herring
2023-12-18  4:39     ` Agarwal, Nikhil
2023-12-15 16:09 ` Greg Kroah-Hartman [this message]
2023-12-15 16:10   ` Greg Kroah-Hartman
2023-12-21  6:42     ` Gangurde, Abhijit
2023-12-21  8:07       ` Greg Kroah-Hartman
2023-12-21  8:40         ` Gangurde, Abhijit
2023-12-21  8:46           ` Greg Kroah-Hartman
2023-12-18  4:40 ` Agarwal, Nikhil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023121551-uncommon-negation-fdda@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nikhil.agarwal@amd.com \
    --cc=nipun.gupta@amd.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox