From: Kyle Tso <kyletso@google.com>
To: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, linux@roeck-us.net,
heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org
Cc: badhri@google.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Kyle Tso <kyletso@google.com>
Subject: [PATCH v6 0/2] mutiple selectable capabilities in tcpm
Date: Sat, 16 Dec 2023 18:46:28 +0800 [thread overview]
Message-ID: <20231216104630.2720818-1-kyletso@google.com> (raw)
updates in v6
dt-bindings: connector: Add child nodes for multiple PD capabilities
- Cherry-picked from https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=dt/next&id=0d3a771610d0e155c9aa305f142f84dda5030fae
- Rob did some modification on it
usb: typec: tcpm: Support multiple capabilities
- Removed the function tcpm_fw_get_properties and merged it to tcpm_fw_get_caps
---
updates in v5
dt-bindings: connector: Add child nodes for multiple PD capabilities
- Fixed DT_CHECK errors
usb: typec: tcpm: Support multiple capabilities
- no change
---
updates in v4
dt-bindings: connector: Add child nodes for multiple PD capabilities
- Modified the structure as corrected in v2
- Modified the commit message
usb: typec: tcpm: Support multiple capabilities
- no change
---
updates in v3
dt-bindings: connector: Add child nodes for multiple PD capabilities
- Updated the commit message
- Remain unchanged for the comments about the property/node
refactor
usb: typec: tcpm: Support multiple capabilities
- Changed the error handling and the usage of the APIs
- Updated the commit message
---
updates in v2
dt-bindings: connector: Add child nodes for multiple PD capabilities
- revised the dt-bindings
usb: typec: tcpm: Support multiple capabilities
- Added missing cleanups in the function tcpm_port_unregister_pd
---
Original cover letter:
In commit a7cff92f0635 ("usb: typec: USB Power Delivery helpers for
ports and partners"), typec_operations has two new ops .pd_get and
.pd_set providing selection of different PD capabilities. This commit
implements these two ops in tcpm.
To support multiple capabilities, new dt-binding properties need to be
defined to create a tree structure for the driver to get each set of
capabilities one by one. The first tier of the child node under
connector is called "capabilities". Under this child node lies several
2nd tier of child nodes whose names are in the pattern of ^caps[0-9]+$.
And the source and sink capabilities are placed in these nodes.
Kyle Tso (2):
dt-bindings: connector: Add child nodes for multiple PD capabilities
usb: typec: tcpm: Support multiple capabilities
.../bindings/connector/usb-connector.yaml | 81 ++--
drivers/usb/typec/tcpm/tcpm.c | 387 ++++++++++++++----
2 files changed, 348 insertions(+), 120 deletions(-)
--
2.43.0.472.g3155946c3a-goog
next reply other threads:[~2023-12-16 10:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-16 10:46 Kyle Tso [this message]
2023-12-16 10:46 ` [PATCH v6 1/2] dt-bindings: connector: Add child nodes for multiple PD capabilities Kyle Tso
2023-12-16 10:46 ` [PATCH v6 2/2] usb: typec: tcpm: Support multiple capabilities Kyle Tso
2023-12-19 13:25 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231216104630.2720818-1-kyletso@google.com \
--to=kyletso@google.com \
--cc=badhri@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox