From: kernel test robot <lkp@intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: drivers/acpi/sleep.c:1208: warning: Function parameter or member 'stage' not described in 'acpi_hibernation_begin_old'
Date: Mon, 18 Dec 2023 04:16:52 +0800 [thread overview]
Message-ID: <202312180432.X748Usi0-lkp@intel.com> (raw)
Hi Rafael,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 0e389834672c723435a44818ed2cabc4dad24429
commit: bb1869012d7b78d1474808cb4c8bd8b272645876 ACPI: PM: Call pm_set_suspend_via_firmware() during hibernation
date: 4 years, 7 months ago
config: x86_64-randconfig-015-20231011 (https://download.01.org/0day-ci/archive/20231218/202312180432.X748Usi0-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231218/202312180432.X748Usi0-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312180432.X748Usi0-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/acpi/sleep.c:424: warning: expecting prototype for acpi_pre_suspend(). Prototype was for acpi_pm_pre_suspend() instead
drivers/acpi/sleep.c:516: warning: Function parameter or member 'acpi_state' not described in 'acpi_pm_start'
drivers/acpi/sleep.c:555: warning: Function parameter or member 'pm_state' not described in 'acpi_suspend_begin'
drivers/acpi/sleep.c:682: warning: Function parameter or member 'pm_state' not described in 'acpi_suspend_begin_old'
>> drivers/acpi/sleep.c:1208: warning: Function parameter or member 'stage' not described in 'acpi_hibernation_begin_old'
vim +1208 drivers/acpi/sleep.c
caea99ef339af8 drivers/acpi/sleep/main.c Rafael J. Wysocki 2008-01-08 1200
d8f3de0d2412bb drivers/acpi/sleep/main.c Rafael J. Wysocki 2008-06-12 1201 /**
d8f3de0d2412bb drivers/acpi/sleep/main.c Rafael J. Wysocki 2008-06-12 1202 * acpi_hibernation_begin_old - Set the target system sleep state to
d8f3de0d2412bb drivers/acpi/sleep/main.c Rafael J. Wysocki 2008-06-12 1203 * ACPI_STATE_S4 and execute the _PTS control method. This
d8f3de0d2412bb drivers/acpi/sleep/main.c Rafael J. Wysocki 2008-06-12 1204 * function is used if the pre-ACPI 2.0 suspend ordering has been
d8f3de0d2412bb drivers/acpi/sleep/main.c Rafael J. Wysocki 2008-06-12 1205 * requested.
d8f3de0d2412bb drivers/acpi/sleep/main.c Rafael J. Wysocki 2008-06-12 1206 */
bb1869012d7b78 drivers/acpi/sleep.c Rafael J. Wysocki 2019-05-16 1207 static int acpi_hibernation_begin_old(pm_message_t stage)
a634cc10164d1c drivers/acpi/sleep/main.c Rafael J. Wysocki 2007-07-19 @1208 {
e49f711cc8f3bf drivers/acpi/sleep/main.c Zhao Yakui 2008-08-12 1209 int error;
e49f711cc8f3bf drivers/acpi/sleep/main.c Zhao Yakui 2008-08-12 1210 /*
e49f711cc8f3bf drivers/acpi/sleep/main.c Zhao Yakui 2008-08-12 1211 * The _TTS object should always be evaluated before the _PTS object.
e49f711cc8f3bf drivers/acpi/sleep/main.c Zhao Yakui 2008-08-12 1212 * When the old_suspended_ordering is true, the _PTS object is
e49f711cc8f3bf drivers/acpi/sleep/main.c Zhao Yakui 2008-08-12 1213 * evaluated in the acpi_sleep_prepare.
e49f711cc8f3bf drivers/acpi/sleep/main.c Zhao Yakui 2008-08-12 1214 */
e49f711cc8f3bf drivers/acpi/sleep/main.c Zhao Yakui 2008-08-12 1215 acpi_sleep_tts_switch(ACPI_STATE_S4);
e49f711cc8f3bf drivers/acpi/sleep/main.c Zhao Yakui 2008-08-12 1216
e49f711cc8f3bf drivers/acpi/sleep/main.c Zhao Yakui 2008-08-12 1217 error = acpi_sleep_prepare(ACPI_STATE_S4);
bb1869012d7b78 drivers/acpi/sleep.c Rafael J. Wysocki 2019-05-16 1218 if (error)
bb1869012d7b78 drivers/acpi/sleep.c Rafael J. Wysocki 2019-05-16 1219 return error;
a634cc10164d1c drivers/acpi/sleep/main.c Rafael J. Wysocki 2007-07-19 1220
bb1869012d7b78 drivers/acpi/sleep.c Rafael J. Wysocki 2019-05-16 1221 if (!nvs_nosave) {
dd4c4f17d722ff drivers/acpi/sleep.c Matthew Garrett 2010-05-28 1222 error = suspend_nvs_alloc();
bb1869012d7b78 drivers/acpi/sleep.c Rafael J. Wysocki 2019-05-16 1223 if (error)
bb1869012d7b78 drivers/acpi/sleep.c Rafael J. Wysocki 2019-05-16 1224 return error;
bb1869012d7b78 drivers/acpi/sleep.c Rafael J. Wysocki 2019-05-16 1225 }
bb1869012d7b78 drivers/acpi/sleep.c Rafael J. Wysocki 2019-05-16 1226
bb1869012d7b78 drivers/acpi/sleep.c Rafael J. Wysocki 2019-05-16 1227 if (stage.event == PM_EVENT_HIBERNATE)
bb1869012d7b78 drivers/acpi/sleep.c Rafael J. Wysocki 2019-05-16 1228 pm_set_suspend_via_firmware();
bb1869012d7b78 drivers/acpi/sleep.c Rafael J. Wysocki 2019-05-16 1229
d8f3de0d2412bb drivers/acpi/sleep/main.c Rafael J. Wysocki 2008-06-12 1230 acpi_target_sleep_state = ACPI_STATE_S4;
ad07277e82deda drivers/acpi/sleep.c Rafael J. Wysocki 2013-08-20 1231 acpi_scan_lock_acquire();
bb1869012d7b78 drivers/acpi/sleep.c Rafael J. Wysocki 2019-05-16 1232 return 0;
3f4b0ef7f2899c drivers/acpi/sleep/main.c Rafael J. Wysocki 2008-10-26 1233 }
3f4b0ef7f2899c drivers/acpi/sleep/main.c Rafael J. Wysocki 2008-10-26 1234
:::::: The code at line 1208 was first introduced by commit
:::::: a634cc10164d1c229fbeca33923e6a0ed939e894 swsusp: introduce restore platform operations
:::::: TO: Rafael J. Wysocki <rjw@sisk.pl>
:::::: CC: Linus Torvalds <torvalds@woody.linux-foundation.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2023-12-17 20:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-17 20:16 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-12-03 6:32 drivers/acpi/sleep.c:1208: warning: Function parameter or member 'stage' not described in 'acpi_hibernation_begin_old' kernel test robot
2023-10-21 14:15 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202312180432.X748Usi0-lkp@intel.com \
--to=lkp@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox