From: Tony Lindgren <tony@atomide.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>, Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
John Ogness <john.ogness@linutronix.de>,
Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: "David S . Miller" <davem@davemloft.net>,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Dhruva Gole" <d-gole@ti.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Johan Hovold" <johan@kernel.org>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: [RFC PATCH v5 2/6] printk: Don't try to parse DEVNAME:0.0 console options
Date: Mon, 18 Dec 2023 09:09:49 +0200 [thread overview]
Message-ID: <20231218071020.21805-3-tony@atomide.com> (raw)
In-Reply-To: <20231218071020.21805-1-tony@atomide.com>
Trying to parse the console for a console=DEVNAME:0.0 style console does
not work as console_setup() tries to make a console index out of any
digits passed in the kernel command line for console. In the DEVNAME:0.0
case, the name can contain a device IO address.
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
kernel/printk/printk.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -2459,6 +2459,10 @@ static int __init console_setup(char *str)
if (console_opt_save(str, brl_options))
return 1;
+ /* Don't attempt to parse a DEVNAME:0.0 style console */
+ if (strchr(str, ':'))
+ return 1;
+
/*
* Decode str into name, index, options.
*/
--
2.43.0
next prev parent reply other threads:[~2023-12-18 7:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 7:09 [RFC PATCH v5 0/6] Add support for DEVNAME:0.0 style hardware based addressing Tony Lindgren
2023-12-18 7:09 ` [RFC PATCH v5 1/6] printk: Save console options for add_preferred_console_match() Tony Lindgren
2023-12-18 15:09 ` Andy Shevchenko
2023-12-18 7:09 ` Tony Lindgren [this message]
2023-12-18 7:09 ` [RFC PATCH v5 3/6] printk: Flag register_console() if console is set on command line Tony Lindgren
2023-12-18 7:09 ` [RFC PATCH v5 4/6] serial: core: Add support for DEVNAME:0.0 style naming for kernel console Tony Lindgren
2023-12-18 7:09 ` [RFC PATCH v5 5/6] serial: core: Handle serial console options Tony Lindgren
2023-12-18 15:23 ` Andy Shevchenko
2023-12-18 7:09 ` [RFC PATCH v5 6/6] serial: 8250: Add preferred console in serial8250_isa_init_ports() Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231218071020.21805-3-tony@atomide.com \
--to=tony@atomide.com \
--cc=andriy.shevchenko@intel.com \
--cc=bigeasy@linutronix.de \
--cc=d-gole@ti.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox