From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: Song Liu <song@kernel.org>
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org,
Paul E Luse <paul.e.luse@linux.intel.com>
Subject: Re: [PATCH 0/3] md: Remove deprecated flavors
Date: Mon, 18 Dec 2023 09:32:01 +0100 [thread overview]
Message-ID: <20231218093201.000020dd@linux.intel.com> (raw)
In-Reply-To: <CAPhsuW6GZnufqFseLvgpMrrX6qRXodX1n89vEbbC-FqTjsWPDg@mail.gmail.com>
On Fri, 15 Dec 2023 07:37:54 -0800
Song Liu <song@kernel.org> wrote:
> Hi Mariusz,
>
> On Fri, Dec 15, 2023 at 3:51 AM Mariusz Tkaczyk
> <mariusz.tkaczyk@linux.intel.com> wrote:
> >
> > On Thu, 14 Dec 2023 14:21:04 -0800
> > Song Liu <song@kernel.org> wrote:
> >
> > > Linear, multipath, and faulty have been marked as deprecated for 2.5
> > > years. Let's remove them.
> > >
> > > Thanks,
> > > Song
> >
> > Hi Song,
> > Great idea!
> >
> > Please note that there are mdadm tests for those levels. I can approve it
> > only when mdadm clean-up is merged. Our tests must pass continuously.
>
> Is the continuous test result available publicly?
We are working on public CI (Paul owns it). On my side I'm not executing all
tests, IMSM only. In this case it is obvious that mdadm tests will stop passing,
I don't need results to see that. We should keep both mdadm and md compatible.
We are continuously adding new MD regression tests to mdadm (at least Kuai is
doing that) so we should also care about removing things.
>
> >
> > It is a nice code complexity improvement so let me know if you would
> > like to get my help with mdadm patches.
>
> On my local tests with mdadm, I need to make changes to the following
> tests:
>
> 00linear...
> 00names...
> 00raid0...
> 00readonly...
> 02lineargrow...
> 03r0assem...
> 04r0update...
> 04update-metadata...
>
> The changes are all straightforward (just remove things related to
> linear/multipath/faulty).
>
Please do not forgot remove dead code from mdadm. For example simple find
"multipath" (case insensitive) reefers me to multiple places with special
handling for this level. We need to remove it from code and documentation.
Can you handle this too?
Oh and last one, I can't find update for md man in your changes. Could you
please remove those levels from md man?
Thanks,
Mariusz
next prev parent reply other threads:[~2023-12-18 8:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 22:21 [PATCH 0/3] md: Remove deprecated flavors Song Liu
2023-12-14 22:21 ` [PATCH 1/3] md: Remove deprecated CONFIG_MD_LINEAR Song Liu
2023-12-15 4:32 ` Christoph Hellwig
2023-12-15 7:04 ` Hannes Reinecke
2024-01-12 9:28 ` Geert Uytterhoeven
2024-01-12 17:08 ` Song Liu
2024-01-12 17:10 ` Christoph Hellwig
2024-01-12 17:11 ` Jens Axboe
2024-01-12 18:27 ` Geert Uytterhoeven
2023-12-14 22:21 ` [PATCH 2/3] md: Remove deprecated CONFIG_MD_MULTIPATH Song Liu
2023-12-15 4:33 ` Christoph Hellwig
2023-12-15 7:05 ` Hannes Reinecke
2023-12-14 22:21 ` [PATCH 3/3] md: Remove deprecated CONFIG_MD_FAULTY Song Liu
2023-12-15 4:33 ` Christoph Hellwig
2023-12-15 7:05 ` Hannes Reinecke
2023-12-15 11:50 ` [PATCH 0/3] md: Remove deprecated flavors Mariusz Tkaczyk
2023-12-15 15:37 ` Song Liu
2023-12-18 8:32 ` Mariusz Tkaczyk [this message]
2023-12-18 16:11 ` Song Liu
2023-12-19 10:46 ` Mariusz Tkaczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231218093201.000020dd@linux.intel.com \
--to=mariusz.tkaczyk@linux.intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=paul.e.luse@linux.intel.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox