From: Mikhail Rudenko <mike.rudenko@gmail.com>
To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Jacopo Mondi <jacopo@jmondi.org>,
Tommaso Merciai <tomm.merciai@gmail.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Mikhail Rudenko <mike.rudenko@gmail.com>
Subject: [PATCH v2 02/20] media: i2c: ov4689: Sort register definitions by address
Date: Mon, 18 Dec 2023 20:40:23 +0300 [thread overview]
Message-ID: <20231218174042.794012-3-mike.rudenko@gmail.com> (raw)
In-Reply-To: <20231218174042.794012-1-mike.rudenko@gmail.com>
Put register defininitions in the order of increasing register
address.
Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com>
---
drivers/media/i2c/ov4689.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/media/i2c/ov4689.c b/drivers/media/i2c/ov4689.c
index ff5213862974..1ae6d9b9c9b3 100644
--- a/drivers/media/i2c/ov4689.c
+++ b/drivers/media/i2c/ov4689.c
@@ -19,15 +19,15 @@
#include <media/v4l2-subdev.h>
#include <media/v4l2-fwnode.h>
-#define CHIP_ID 0x004688
-#define OV4689_REG_CHIP_ID 0x300a
-
#define OV4689_XVCLK_FREQ 24000000
#define OV4689_REG_CTRL_MODE 0x0100
#define OV4689_MODE_SW_STANDBY 0x0
#define OV4689_MODE_STREAMING BIT(0)
+#define OV4689_REG_CHIP_ID 0x300a
+#define CHIP_ID 0x004688
+
#define OV4689_REG_EXPOSURE 0x3500
#define OV4689_EXPOSURE_MIN 4
#define OV4689_EXPOSURE_STEP 1
@@ -41,12 +41,12 @@
#define OV4689_GAIN_STEP 1
#define OV4689_GAIN_DEFAULT 0x80
+#define OV4689_REG_VTS 0x380e
+
#define OV4689_REG_TEST_PATTERN 0x5040
#define OV4689_TEST_PATTERN_ENABLE 0x80
#define OV4689_TEST_PATTERN_DISABLE 0x0
-#define OV4689_REG_VTS 0x380e
-
#define REG_NULL 0xFFFF
#define OV4689_REG_VALUE_08BIT 1
--
2.43.0
next prev parent reply other threads:[~2023-12-18 17:41 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 17:40 [PATCH v2 00/20] Omnivision OV4689 refactoring and improvements Mikhail Rudenko
2023-12-18 17:40 ` [PATCH v2 01/20] media: i2c: ov4689: Clean up and annotate the register table Mikhail Rudenko
2024-02-23 11:23 ` Laurent Pinchart
2024-02-23 16:40 ` Mikhail Rudenko
2024-02-23 20:10 ` Laurent Pinchart
2023-12-18 17:40 ` Mikhail Rudenko [this message]
2024-02-23 11:22 ` [PATCH v2 02/20] media: i2c: ov4689: Sort register definitions by address Laurent Pinchart
2023-12-18 17:40 ` [PATCH v2 03/20] media: i2c: ov4689: Fix typo in a comment Mikhail Rudenko
2023-12-18 17:40 ` [PATCH v2 04/20] media: i2c: ov4689: CCI conversion Mikhail Rudenko
2023-12-18 17:40 ` [PATCH v2 05/20] media: i2c: ov4689: Remove i2c_client from ov4689 struct Mikhail Rudenko
2023-12-18 17:40 ` [PATCH v2 06/20] media: i2c: ov4689: Refactor ov4689_set_ctrl Mikhail Rudenko
2024-01-08 11:16 ` Sakari Ailus
2024-01-08 14:57 ` Mikhail Rudenko
2023-12-18 17:40 ` [PATCH v2 07/20] media: i2c: ov4689: Use sub-device active state Mikhail Rudenko
2024-02-23 11:28 ` Laurent Pinchart
2024-02-23 16:26 ` Mikhail Rudenko
2023-12-18 17:40 ` [PATCH v2 08/20] media: i2c: ov4689: Enable runtime PM before registering sub-device Mikhail Rudenko
2024-02-23 11:29 ` Laurent Pinchart
2023-12-18 17:40 ` [PATCH v2 09/20] media: i2c: ov4689: Use runtime PM autosuspend Mikhail Rudenko
2024-01-08 11:18 ` Sakari Ailus
2024-01-08 15:06 ` Mikhail Rudenko
2024-01-08 16:03 ` Sakari Ailus
2024-02-23 8:19 ` Sakari Ailus
2024-02-23 15:18 ` Mikhail Rudenko
2024-02-24 19:38 ` Sakari Ailus
2024-02-25 14:58 ` Mikhail Rudenko
2023-12-18 17:40 ` [PATCH v2 10/20] media: i2c: ov4689: Remove max_fps field from struct ov4689_mode Mikhail Rudenko
2023-12-18 17:40 ` [PATCH v2 11/20] media: i2c: ov4689: Make horizontal blanking configurable Mikhail Rudenko
2023-12-18 17:40 ` [PATCH v2 12/20] media: i2c: ov4689: Implement vflip/hflip controls Mikhail Rudenko
2024-02-23 8:26 ` Sakari Ailus
2024-02-23 15:21 ` Mikhail Rudenko
2024-02-24 20:04 ` Sakari Ailus
2024-02-25 14:15 ` Mikhail Rudenko
2023-12-18 17:40 ` [PATCH v2 13/20] media: i2c: ov4689: Implement digital gain control Mikhail Rudenko
2024-02-23 11:30 ` Laurent Pinchart
2023-12-18 17:40 ` [PATCH v2 14/20] media: i2c: ov4689: Implement manual color balance controls Mikhail Rudenko
2024-02-23 11:31 ` Laurent Pinchart
2023-12-18 17:40 ` [PATCH v2 15/20] media: i2c: ov4689: Move pixel array size out of struct ov4689_mode Mikhail Rudenko
2024-02-23 11:33 ` Laurent Pinchart
2024-02-23 11:36 ` Laurent Pinchart
2024-02-23 16:31 ` Mikhail Rudenko
2024-02-23 16:29 ` Mikhail Rudenko
2023-12-18 17:40 ` [PATCH v2 16/20] media: i2c: ov4689: Set timing registers programmatically Mikhail Rudenko
2024-02-23 11:44 ` Laurent Pinchart
2024-02-23 16:34 ` Mikhail Rudenko
2023-12-18 17:40 ` [PATCH v2 17/20] media: i2c: ov4689: Configurable analogue crop Mikhail Rudenko
2023-12-18 17:40 ` [PATCH v2 18/20] media: i2c: ov4689: Eliminate struct ov4689_mode Mikhail Rudenko
2023-12-18 17:40 ` [PATCH v2 19/20] media: i2c: ov4689: Refactor ov4689_s_stream Mikhail Rudenko
2024-02-23 11:48 ` Laurent Pinchart
2024-02-23 16:47 ` Mikhail Rudenko
2023-12-18 17:40 ` [PATCH v2 20/20] media: i2c: ov4689: Implement 2x2 binning Mikhail Rudenko
2024-02-21 15:02 ` [PATCH v2 00/20] Omnivision OV4689 refactoring and improvements Mikhail Rudenko
2024-02-23 8:15 ` Sakari Ailus
2024-02-23 8:43 ` Sakari Ailus
2024-02-23 15:47 ` Mikhail Rudenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231218174042.794012-3-mike.rudenko@gmail.com \
--to=mike.rudenko@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dave.stevenson@raspberrypi.com \
--cc=jacopo@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomm.merciai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox